IndexRange of style span

Hi Tomas, I have been testing this. it seems there is an issue.

In "word", if you make wo red, and detect the span index range, it will be correct,
"wo" is a range, and "rd" is a range.

but if you apply a color again to "or", so coloring should be like "w" "or" "d", and you click in "or", the span will only detect the O (from previously applied style.

Can you reproduce this?
I am using the richTextArea.getStyleRangeAtPosition(caretpos);

[TomasMikula]

Hi Maher,

it's best if you post the code. I guess what is happening here is that when you get the style spans for "or", you get two style spans, each spanning 1 character. When you the call mapStyles, this switches the styles in the spans, but there are still two spans of length 1. The text area should probably merge them together, if they have the same style (in terms of equals). It is already merging adjacent ranges with the same style when you use setStyle.

Yes that is my guess too.

[TomasMikula]

Please, try the new jar.

Hi Tomas, I tried it. It seems to works on the first and second attempts, but then starts missing characters on the both ends (before and after).
also, noticed that if I type, then apply style to the text. hit enter.. then type more, click in the new typed text (after hitting enter) and try to apply a style to the span at caret position (so new entered text), it applies style to the previous text (a couple of lines up).

I'll do more testing to try to narrow down the issue.

I did further testing, I think there is something to do with the line number somewhere
Because if I apply a style to a word (in span), it gets applied to the span relatively above it but in the line immediately above it.

[TomasMikula]

Can you post a self-contained (runnable) code that demonstrates the problem?

On Wed, Apr 30, 2014 at 12:06 AM, melkhaldi notifications@github.comwrote:

I did further testing, I think there is something to do with the line
number somewhere
Because if I apply a style to a word (in span), it gets applied to the
span relatively above it but in the line immediately above it.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/50#issuecomment-41738294
.

A runnable example will take me a long time to factor out. For now, these are the code bits I am using in the following steps:

-Type text:
-Apply style to selection in text. (do this a few times over different selections).
-Do more typing.. hit enter to start new lines, do more typing, etc.
-Here, anything typed uses the caret style, which is driven by the subscribe method. so the newly entered text has not been "chopped up".
-Click somewhere in the newly added text, and apply a new style to the span at caret position.
-styles gets applied but to a span that is in previous lines, and is not really to a full span as one would expect. It misses out on a couple of characters.

This is the code I am using to:

**Code to apply style to Selection (style coming as a cleaned up CSS string). Something like:
style = "-fx-font-family: Arial;-fx-font-size: 16;-fx-font-weight: normal;-fx-fill: rgb(153,204,255);-fx-font-style: normal;-fx-underline: false;"

public void applyNewStyleToSelection(TextEditorViewPort port, string style) {
    IndexRange range = port.richTextArea.getSelection();
    if (range.getEnd() > range.getStart()) {
        port.richTextArea.setStyle(range.getStart(), range.getEnd(),  style);
    }

}

**Code to apply style to a span (triggered by hitting a button).

 public void applyToSpanAtCaretCSS(String styleUpdate) {
    int pos = activePort.richTextArea.caretPositionProperty().get();
    int start = activePort.richTextArea.getStyleRangeAtPosition(pos).getStart();
    int end = activePort.richTextArea.getStyleRangeAtPosition(pos).getEnd();
    if (start < end) {
        activePort.richTextArea.setStyle(start, end, styleUpdate);
        System.out.println("Span is:" + activePort.richTextArea.getText(start, end));
        System.out.println("Style is is:" + styleUpdate);
    } else {
        System.out.println("Indices don't work");
    }
}

[TomasMikula]

Can you narrow down which method is problematic? Is it getStyleRangeAtPosition or setStyle? Does getStyleRangeAtPosition return a range such that pos is not even between start and end?

I believe the issue is with the getStyleRangeAtPosition.

I also verified this by listening to caret change and printing text for the
detected style range using a getText(rangestart, rangeEnd). the printed
text string is not similar to what is being styled in the text area.

The setStyle works fine. I use it everywhere else and things work as
expected. including apply to selection and to paragraph.

On Tue, Apr 29, 2014 at 5:08 PM, TomasMikula notifications@github.comwrote:

Can you narrow down which method is problematic? Is it
getStyleRangeAtPosition or setStyle? Does getStyleRangeAtPosition return
a range such that pos is not even between start and end?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/50#issuecomment-41747263
.

on another note, I just printed the style at caret using:
getStyleAtPosition, this is what I get (I only change colors):

END: Style At position is: -fx-font-family: Arial;-fx-font-size:
16;-fx-font-weight: normal;-fx-fill: rgb(0,0,0);-fx-font-style:
normal;-fx-underline: false;-fx-fill: rgb(0,0,0);-fx-fill:
rgb(0,51,51);-fx-fill: rgb(0,0,0);-fx-fill: rgb(0,102,102);-fx-fill:
rgb(0,0,0);-fx-fill: rgb(0,76,153);-fx-fill: rgb(0,0,0);-fx-fill:
rgb(0,102,204);-fx-fill: rgb(0,0,0);-fx-fill: rgb(0,128,255);-fx-fill:
rgb(0,0,0);-fx-fill: rgb(51,153,255);-fx-fill: rgb(0,0,0);-fx-fill:
rgb(102,178,235);-fx-fill: rgb(0,0,0);-fx-fill: rgb(153,204,255);-fx-fill:
rgb(0,0,0);-fx-fill: rgb(153,153,255);-fx-fill: rgb(0,0,0);-fx-fill:
rgb(204,204,255);-fx-fill: rgb(0,0,0);-fx-fill: rgb(153,153,255);-fx-fill:
rgb(0,0,0);-fx-fill: rgb(204,153,255);-fx-fill: rgb(0,0,0);-fx-fill:
rgb(255,153,255);-fx-fill: rgb(0,0,0);-fx-fill: rgb(255,102,255);-fx-fill:
rgb(0,0,0);-fx-fill: rgb(255,51,255);-fx-fill: rgb(255,51,255);-fx-fill:
rgb(255,51,255);-fx-fill: rgb(255,51,255);

something in the setStyle() probably cases the range detection to break.
The setStyle concatenates a new color value, so the string is actually not
the same. if the getStyleRangeAtPosition looks for string similarity, which
I guess it might be doing, this this is why?

On Tue, Apr 29, 2014 at 5:25 PM, Maher Elkhaldi m.s.khaldi@gmail.comwrote:

I believe the issue is with the getStyleRangeAtPosition.

I also verified this by listening to caret change and printing text for
the detected style range using a getText(rangestart, rangeEnd). the
printed text string is not similar to what is being styled in the text area.

The setStyle works fine. I use it everywhere else and things work as
expected. including apply to selection and to paragraph.

On Tue, Apr 29, 2014 at 5:08 PM, TomasMikula notifications@github.comwrote:

Can you narrow down which method is problematic? Is it
getStyleRangeAtPosition or setStyle? Does getStyleRangeAtPosition return
a range such that pos is not even between start and end?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/50#issuecomment-41747263
.

[TomasMikula]

In the code you posted before, can you add

if(pos < start || pos > end) {
    throw new AssertionError("style range [" + start + "," + end + "] does not contain caret position " + pos);
}

after

int pos = activePort.richTextArea.caretPositionProperty().get();
int start = activePort.richTextArea.getStyleRangeAtPosition(pos).getStart();
int end = activePort.richTextArea.getStyleRangeAtPosition(pos).getEnd();

and see if the exception gets thrown?

no exception is thrown.

On Tue, Apr 29, 2014 at 6:51 PM, TomasMikula notifications@github.comwrote:

In the code you posted before, can you add

if(pos < start || pos > end) {
throw new AssertionError("style range [" + start + "," + end + "] does not contain caret position " + pos);}

after

int pos = activePort.richTextArea.caretPositionProperty().get();int start = activePort.richTextArea.getStyleRangeAtPosition(pos).getStart();int end = activePort.richTextArea.getStyleRangeAtPosition(pos).getEnd();

and see if the exception gets throws?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/50#issuecomment-41752896
.

so it must be in the setStyle(), right?

On Tue, Apr 29, 2014 at 6:59 PM, Maher Elkhaldi m.s.khaldi@gmail.comwrote:

no exception is thrown.

On Tue, Apr 29, 2014 at 6:51 PM, TomasMikula notifications@github.comwrote:

In the code you posted before, can you add

if(pos < start || pos > end) {
throw new AssertionError("style range [" + start + "," + end + "] does not contain caret position " + pos);}

after

int pos = activePort.richTextArea.caretPositionProperty().get();int start = activePort.richTextArea.getStyleRangeAtPosition(pos).getStart();int end = activePort.richTextArea.getStyleRangeAtPosition(pos).getEnd();

and see if the exception gets throws?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/50#issuecomment-41752896
.

[TomasMikula]

So it seems.