Dvorak keyboard on OSX not supported when doing cut and paste CMD-V, etc

[hoebat]

When CMD-C, X, V, A, etc... is pressed while the keyboard is on Dvorak, it does not work as expected but goes back to the original Qwerty Keys

'C' for Dvorak maps to Qwerty I key, CMD-C is actually CMD-I
'V' for Dvorak maps to Qwerty . key, CMD-V is actually CMD-.
'X' for Dvorak maps to Qwerty B key, CMD-X is actually CMD-B

To get it working, CMD-'QWERTY-C' has to be used whilst on Dvorak.

[Jugen]

I think this is related to https://bugs.openjdk.java.net/browse/JDK-8090257

[dgelessus]

Similar issue here with the German QWERTZ layout. The shortcut for "Undo" should be Cmd+Z, but I have to press Cmd+Y (which would be Cmd+Z on a QWERTY keyboard).

I think the issue is not JavaFX, but rather that RichTextFX binds the undo/redo shortcuts by key code (i. e. physical key) rather than key character:

RichTextFX/richtextfx/src/main/java/org/fxmisc/richtext/GenericStyledAreaBehavior.java

Lines 70 to 73 in 567e7e8

	consume(keyPressed(Z, SHORTCUT_DOWN), (b, e) -> b.view.undo()),
	consume(
	anyOf(keyPressed(Y, SHORTCUT_DOWN), keyPressed(Z, SHORTCUT_DOWN, SHIFT_DOWN)),
	(b, e) -> b.view.redo())

Replacing the uses of Z and Y (which are KeyCode constants) with "Z" and "Y" (strings) should make the key combination dependent on the character instead of the code. The same applies to the other key combinations that involve letters (Cmd+A, +X, +C, +V).

[Jugen]

@dgelessus yes I agree. That seems to have been the workaround for this problem with regards to AWT key events. See: [macosx] Dvorak keyboard mapping not honored when CMD/CTRL key pressed

[Jugen]

@zcaudate and @dgelessus Could you both please try the following simple program with your respective keyboard layouts and give me feedback please.

[dgelessus]

@Jugen The test program recognizes the keys based on my selected layout, i. e. pressing Cmd and the German Z key (i. e. the English Y key) is recognized as Undo. This is the behavior that I would also expect in the RichTextFX editor.

[hoebat]

@Jugen I believe this fixes the issue.

[Jugen]

Ok, I'll try and do a PR based on this in the next few days ....

[Jugen]

There's a proposal to change from KeyCharacterCombination to KeyCodeCombination (see #1253), which could affect Dvorak and German keyboard users.

I've updated the RichTextFX maven 1.0.0-SNAPSHOT for testing. If possible please test and provide feedback.