Make CaretNode transparent to mouse picking (fixes #124)#1032
Merged
Jugen merged 1 commit intoFXMisc:masterfrom Jul 20, 2021
Merged
Conversation
If you install a mouse handler on a TextExt area using setOnMouseClicked(), there's a small chance that your mouse click will be ignored (this happens approximately one time in ten in my experience). The problem occurs when you click at the exact same position as the flashing caret while the caret is visible; this confuses the java FX mouse-picking algorithm, which causes the MouseEvent to be sent to the ParagraphText node rather than the TextExt. The fix is simply to make the caret transparent to mouse picking. See this link for more evidence + screenshots : FXMisc#124
Collaborator
|
@chrisf-london Excellent ! Thank you very much :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you install a mouse handler on a TextExt area using setOnMouseClicked() or similar, there's a small chance that your mouse click will be ignored. This happens approximately one time in ten in my experience. The problem occurs when you click at the exact same position as the flashing caret while the caret is visible; this confuses the java FX mouse-picking algorithm, which causes the event to be sent to the ParagraphText node rather than the TextExt. The fix is simply to make the caret transparent to mouse picking.
See this link for more evidence + screenshots : #124 (comment)
(should be a safe change, I can't think of any reason you'd want the caret to be pickable)