Skip to content

fix getCharacterBoundsOnScreen #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jugen merged 1 commit into from
Jan 25, 2022
Merged

fix getCharacterBoundsOnScreen #1076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions richtextfx/src/main/java/org/fxmisc/richtext/GenericStyledArea.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1037,6 +1037,25 @@ public Optional<Bounds> getCharacterBoundsOnScreen(int from, int to) {
throw new IllegalArgumentException(String.format("To is greater than area's length. length=%s, to=%s", getLength(), to));
}

if (from == to) {
CaretNode cursor = new CaretNode( "", this, from );
int parIdx = offsetToPosition( from, Bias.Forward ).getMajor();
ParagraphBox<?,?,?> paragrafBox = virtualFlow.getCell( parIdx ).getNode();
paragrafBox.caretsProperty().add( cursor );
Bounds cursorBounds = paragrafBox.getCaretBoundsOnScreen( cursor );
paragrafBox.caretsProperty().remove( cursor );

if ( cursorBounds != null && ! cursorBounds.isEmpty() )
{
Bounds emptyCharBounds = new BoundingBox(
cursorBounds.getMinX()+1, cursorBounds.getMinY()+1,
cursorBounds.getWidth()-1, cursorBounds.getHeight()-2
);
return Optional.of( emptyCharBounds );
}
return Optional.empty();
}

// no bounds exist if range is just a newline character
if (getText(from, to).equals("\n")) {
return Optional.empty();
Expand Down
⚡