Resolve #1293 - Partial fix for incorrect caret position after Undo (#1295)#1295
Merged
Jugen merged 2 commits intoFXMisc:masterfrom Nov 19, 2025
Merged
Resolve #1293 - Partial fix for incorrect caret position after Undo (#1295)#1295Jugen merged 2 commits intoFXMisc:masterfrom
Jugen merged 2 commits intoFXMisc:masterfrom
Conversation
Jugen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concerns
Issue with this is that we cannot really fix the original issue without causing major impact to all users.
Instead this is a simple fix in UndoUtils along with a lot of UT and some refactoring of the TextChange structure.
Limitations
It seems that the code to merge changes has some cases that are not correct. UT were created to cover the existing behaviour, even when that behaviour seemed incorrect or incomplete.