Skip to content

Finish migration to stable release (WellBehavedFX 0.3) of new InputMa…#296

Merged
TomasMikula merged 1 commit intoFXMisc:masterfrom
JordanMartinez:finishMigration
Apr 23, 2016
Merged

Finish migration to stable release (WellBehavedFX 0.3) of new InputMa…#296
TomasMikula merged 1 commit intoFXMisc:masterfrom
JordanMartinez:finishMigration

Conversation

@JordanMartinez
Copy link
Copy Markdown
Contributor

@JordanMartinez JordanMartinez commented Apr 23, 2016

…p behavior-handling approach

@TomasMikula
Copy link
Copy Markdown
Member

TomasMikula commented Apr 23, 2016

Thanks!

@TomasMikula TomasMikula merged commit 6544cd0 into FXMisc:master Apr 23, 2016
@TomasMikula
Copy link
Copy Markdown
Member

TomasMikula commented Apr 23, 2016 •
edited
Loading

Looking at it now, StyledTextAreaBehavior#dispose() is not necessary any more. It was meant to be called when changing a skin. But now the same behavior is there for the whole lifetime of the text area, so there is no need to dispose it. It will go away when the area goes.

@JordanMartinez JordanMartinez deleted the finishMigration branch April 23, 2016 23:49
@JordanMartinez
Copy link
Copy Markdown
Contributor Author

JordanMartinez commented Apr 24, 2016

Ok. I'll add a new PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JordanMartinez @TomasMikula
⚡