Removed AreaFactory#305
Merged
TomasMikula merged 1 commit intoFXMisc:masterfrom May 10, 2016
JordanMartinez:removeAreaFactory
Merged
Removed AreaFactory#305TomasMikula merged 1 commit intoFXMisc:masterfrom JordanMartinez:removeAreaFactory
TomasMikula merged 1 commit intoFXMisc:masterfrom
JordanMartinez:removeAreaFactory
Conversation
The class' purposes: - clone StyledTextArea or one of its three subclasses (no longer needed due to EditableStyledDocument now being public as an interface) - add scroll bars by embedding the area into a VirtualizedScrollPane (more of a convenience method than anything else) Cloning is no longer needed. Embedding it had an annoying leads-to-more-boilerplate issue: one couldn't modify the area before it was embedded into the pane. So, it seemed simpler to remove this class entirely and just tell developers to embed the area in their own code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The class' purposes:
clone StyledTextArea or one of its three subclasses (no longer needed due to EditableStyledDocument now being public as an interface)
add scroll bars by embedding the area into a VirtualizedScrollPane (more of a convenience method than anything else)
Cloning is no longer needed. Embedding it had an annoying leads-to-more-boilerplate issue: one couldn't modify the area before it was embedded into the pane.
So, it seemed simpler to remove this class entirely and just tell developers to embed the area in their own code.