Handle drag events only if mouse release occurred inside of view#371
Merged
TomasMikula merged 1 commit intoFXMisc:masterfrom Oct 4, 2016
JordanMartinez:abortDragOnOutsideViewMouseRelease
Merged
Handle drag events only if mouse release occurred inside of view#371TomasMikula merged 1 commit intoFXMisc:masterfrom JordanMartinez:abortDragOnOutsideViewMouseRelease
TomasMikula merged 1 commit intoFXMisc:masterfrom
JordanMartinez:abortDragOnOutsideViewMouseRelease
Conversation
Member
|
Shouldn't the test be inside of the |
Contributor
Author
The caret will still move then, but that's what happens in a TextArea, too, (just tested it). So, yeah, it should. |
Contributor
Author
|
I've updated the PR |
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #321