Fix computing hit character if padding is set on the paragraph-text#396
Merged
TomasMikula merged 1 commit intoFXMisc:masterfrom Dec 26, 2016
Merged
Fix computing hit character if padding is set on the paragraph-text#396TomasMikula merged 1 commit intoFXMisc:masterfrom
TomasMikula merged 1 commit intoFXMisc:masterfrom
Conversation
… paragraph-text
To reproduce this, apply a large padding (as below), click at some text in the styled text area and see where the caret is positioned. Without this fix the caret is always some characters right to the click location.
.styled-text-area .paragraph-box .paragraph-text {
-fx-padding: 0 10em 0 10em;
}
.styled-text-area .paragraph-box:first-paragraph .paragraph-text {
-fx-padding: 10em 10em 0 10em;
}
.styled-text-area .paragraph-box:last-paragraph .paragraph-text {
-fx-padding: 0 10em 10em 10em;
}
JFormDesigner
pushed a commit
to JFormDesigner/markdown-writer-fx
that referenced
this pull request
Nov 18, 2016
…TextFX FXMisc/RichTextFX#396 also moved :first-paragraph below :last-paragraph to fix top padding in case editor contains only one line
Member
Collaborator
|
@JFormDesigner very cool ! I came across the same issue some days ago, and now its already fixed 👍 |
Member
|
No merge conflict after all :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes computing hit character (at mouse press) if padding is set on the paragraph-text.
To reproduce this, apply a large padding (as below), click at some text in the styled text area and see where the caret is positioned. Without this fix the caret is always some characters right to the click location.