Make positionCaret package-private#415
Merged
JordanMartinez merged 1 commit intoFXMisc:masterfrom Jan 16, 2017
JordanMartinez:positionCaret
Merged
Make positionCaret package-private#415JordanMartinez merged 1 commit intoFXMisc:masterfrom JordanMartinez:positionCaret
positionCaret package-private#415JordanMartinez merged 1 commit intoFXMisc:masterfrom
JordanMartinez:positionCaret
Conversation
Contributor
Author
|
For now, I'm going to merge this. We can always expose it later on as a better-named method. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this may have value beyond what I know for code editors and the like, I have to ask: why did you originally implement this method? Is making this method package private desirable? AFAIK, we're only doing that because many confused
moveTo's functionality forpositionCaret, since the latter implies that more so than the former.In my opinion, it would be better to rename
moveToto include "caret" in it (moveCaretTo?moveCaret?caretTo?) and renamepositionCaretto include more explanatory details (positionCaretDisconnectedly?positionCaretSeparately?).