Speed up test fx tests#503
Merged
JordanMartinez merged 2 commits intoFXMisc:masterfrom May 11, 2017
JordanMartinez:speedUpTestFXTests
Merged
Speed up test fx tests#503JordanMartinez merged 2 commits intoFXMisc:masterfrom JordanMartinez:speedUpTestFXTests
JordanMartinez merged 2 commits intoFXMisc:masterfrom
JordanMartinez:speedUpTestFXTests
Conversation
- replaces all "clickOn(area)" calls with "*clickOnFirstLine()" This speeds up the test since the mouse doesn't move from the center to the top-left corner and back again throughout the tests that are run. - shortened "some user-inputted text" to "some text"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the mouse moves from the center of the area (due to
clickOn(area)) to the top left portion of the first line and vice versa a couple of times in the test. This causes the test suite to take longer than necessary.gradle teston my machine (I rangradle cleanbefore running the tests):Before | After (in seconds)
18.975 | 15.514