Include implementation and specification version info in MANIFEST.MF file in outputted JARs (#476)#517
Conversation
Manifest files were added to the RichTextFX libraries. Implementation and specification version are being set 0.7.0-M6 and 0.7.0 respectively. See http://semver.org.
|
Thanks for the PR. I asked you to do this because I use Gradle and have never had to deal with the Manifest file. So, I figured you would know what was needed more than I, and your PR would include the needed information for your particular situation. That being said, I'm cautious about merging this for
version = '0.7.0-M6'
ext.specificationVersion = '0.7.0'@TomasMikula seems to leave the project version as is so he can make snapshot releases very quickly. He only overrides that variable temporarily when he makes a new release. Personally, I'm fine with what you've done, but he's the one who owns the project. I also like the idea of using that plugin, but that choice is up to Tomas.
|
If the values are set temporarily or not shouldn't matter. I've tried to use the https://github.com/palantir/gradle-git-version plugin, but it could not get the version string from the Git tags. The
For more information about package versioning see Java™ Product Versioning. |
Aye, the X.Y.Z is what we've typically been following. However, we stopped the base area from extending I think the plugin only works if you first tag the commit and then run that command. If you did that and it still didn't work, then I have no idea! 😄
Ahh... ok. That clarifies why the two values are necessary. For right now, let's leave the project version as is, but keep the specification version as |
|
That's fine. Done. |
|
Thanks. |
Manifest files were added to the RichTextFX libraries. Implementation and specification version were set to 0.7.0-M6 and 0.7.0 respectively. See http://semver.org.
Note that the version information must be updated manually. They also might be derived from Git tags
using Gradle plugins like https://github.com/palantir/gradle-git-version.