Inline navigation into caret selection#540
Merged
JordanMartinez merged 19 commits intoFXMisc:masterfrom Jul 9, 2017
JordanMartinez:inlineNavigationIntoCaretSelection
Merged
Inline navigation into caret selection#540JordanMartinez merged 19 commits intoFXMisc:masterfrom JordanMartinez:inlineNavigationIntoCaretSelection
JordanMartinez merged 19 commits intoFXMisc:masterfrom
JordanMartinez:inlineNavigationIntoCaretSelection
Conversation
Note: selectLine is not yet implemented as this will require some modification to GenericStyledArea, ParagraphBox, and ParagraphText
Calling `preceding` or `following` already calculates the next break, so this is not needed when numOfBreaks = 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to inline
BoundedSelectionintoNavigationActions, so that the former could replace the latter but with clearer API that has convenience methods.I also think that
BoundedSelectionshould be renamed toCaretSelectionBind(or something else other thanbind) since it handles these two objects together.