Enhancement: Selecting a newline char selects the rest of the line#564
Merged
JordanMartinez merged 1 commit intoFXMisc:masterfrom Aug 8, 2017
JordanMartinez:selection
Merged
Enhancement: Selecting a newline char selects the rest of the line#564JordanMartinez merged 1 commit intoFXMisc:masterfrom JordanMartinez:selection
JordanMartinez merged 1 commit intoFXMisc:masterfrom
JordanMartinez:selection
Conversation
Contributor
Author
|
I decided to refactor |
JFormDesigner
pushed a commit
to JFormDesigner/RichTextFX
that referenced
this pull request
Sep 7, 2017
…Misc#549 / FXMisc#564) also closing rectangle path in createRectangle()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #549 according to the IntelliJ style
Note: this PR should be refactored because
getParagraphSelectionnow returnsIndexRange(start, paragraph.length() + 1)in some cases.I'd like to say that there should be two separate methods: one for getting just the range inside the paragraph and another that adds one if it includes the newline character.