fixed caret positioning in wrapped lines (issue #423)

[JFormDesigner]

This PR fixes some issues with caret positioning in wrapped lines:

1. pressing DOWN key at end of line now moves caret to end of next line (and not beginning of line after next line).
   E.g. if caret is at | then DOWN key moves it to ^ (and not * as before).

01234|
678^
*01

2. UP key now always works as expected (and no longer "locks" at * as before)

3. when clicking with the mouse after text in a wrapped line (e.g. right to ^), then the caret is now positioned at the end of the hit line (and not at the beginning of the next line as before)

Here is some code to reproduce:

import javafx.application.Application;
import javafx.scene.Scene;
import javafx.stage.Stage;
import org.fxmisc.flowless.VirtualizedScrollPane;
import org.fxmisc.richtext.InlineCssTextArea;

public class HitWrappedBug extends Application {

    @Override
    public void start(Stage primaryStage) throws Exception {
        InlineCssTextArea area = new InlineCssTextArea("01234 678 01");
        area.setWrapText(true);
        area.setStyle("-fx-font-size: 30pt");
        VirtualizedScrollPane<InlineCssTextArea> vsPane = new VirtualizedScrollPane<>(area);

        Scene scene = new Scene(vsPane, 50, 400);
        primaryStage.setScene(scene);
        primaryStage.show();
    }
}

I think this fixes #423

[JordanMartinez]

Did you break this up so that it's easier to read? Or is this "noise" (as some might call it) unintentional?

[JFormDesigner]

No. The lines variable is used in a if statement to check whether this is a wrapped paragraph 😉

[JordanMartinez]

Ah... I see now. Sorry, I misread it.

[JordanMartinez]

I'll submit a PR to your repo with a test that can tell us for sure.

[JordanMartinez]

@JFormDesigner In your PR, could you add MultilineJaggerdTests (see below) into NavigationTests by following the example below?

Edit: Sorry, I said before I'd submit a PR to yours. I've pulled a local branch of yours with my test and it works. Please merge my PR to yours and then I'll merge yours here.

[JordanMartinez]

Also, thank you for figuring out a way to resolve this. I'd tried a number of times and never got anything to work since I didn't understand the internal API for TextLayout.