Decouple style from segment object#590
Merged
JordanMartinez merged 4 commits intoFXMisc:masterfrom Sep 25, 2017
JordanMartinez:stylelessSeg
Merged
Decouple style from segment object#590JordanMartinez merged 4 commits intoFXMisc:masterfrom JordanMartinez:stylelessSeg
JordanMartinez merged 4 commits intoFXMisc:masterfrom
JordanMartinez:stylelessSeg
Conversation
Contributor
Author
|
@afester @JFormDesigner any objections to or comments on this? Also, this PR isn't completely "clean" when it comes to its scope. I exposed some things or renamed methods that I later realized didn't need to be exposed/renamed. |
Collaborator
|
I can confirm that #584 does not occur anymore with this PR, so 👍 from my side |
Contributor
|
👍 I've tested this PR with Markdown Writer FX and it works without problems. Thanks. |
This was referenced Sep 28, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #567
Note: in the current state of this PR, I reverted the change in #578, which fixed #573. I converted the example code into a TestFX test, and it passes.