Cleanup integration test#601
Merged
JordanMartinez merged 23 commits intoFXMisc:masterfrom Oct 1, 2017
JordanMartinez:cleanupIntegrationTest
Merged
Cleanup integration test#601JordanMartinez merged 23 commits intoFXMisc:masterfrom JordanMartinez:cleanupIntegrationTest
JordanMartinez merged 23 commits intoFXMisc:masterfrom
JordanMartinez:cleanupIntegrationTest
Conversation
Contributor
Author
|
I'm out of time for today, but I am going to see if the Mac build will pass if I run the HitTests tests that currently fail on Mac now that we have a more accurate way of determining the caret's paragraph |
Contributor
Author
|
@JFormDesigner Per your comments here, I've rewritten some tests to use the |
Contributor
Author
Contributor
Author
|
@afester I appreciate that you submitted the PR, but I decided to revert what you did in #589 (the glass adapter) in this PR. We may need to revert my change, so that it's back to yours (at least when Gradle detects that Windows is running it). I hope to know more once I get the Windows CI set up properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To summarize:
NavigationTestsinto their own separate files for easier managementRichTextFXTestBase) in case one needs to use a different area flavor (e.g.GenericStyledArea) while still having access to OS-related things and position helper methodsContextMenuTests, clear clipboard before tests run)StringBuilderto only do so oncegetCharacterBoundsOnScreen(see commit messages for full list of changes)