Skip to content

Get viewport height; show paragraph region; clean up source code (boilerplate & organization)#632

Merged
JordanMartinez merged 7 commits intoFXMisc:masterfrom
JordanMartinez:viewportHeightAndReduceBoilerplate
Oct 27, 2017
Merged

Get viewport height; show paragraph region; clean up source code (boilerplate & organization)#632
JordanMartinez merged 7 commits intoFXMisc:masterfrom
JordanMartinez:viewportHeightAndReduceBoilerplate

Conversation

@JordanMartinez
Copy link
Copy Markdown
Contributor

@JordanMartinez JordanMartinez commented Oct 27, 2017

Adds API to get the viewport's height and show a specific region of a given paragraph

Otherwise, cleans up the source code a bit more by

  • removing unused methods
  • using properties and default methods to reduce boilerplate
  • put package-private and private methods in their own spots in the source code.

@JordanMartinez JordanMartinez changed the title Viewport height and reduce boilerplate Get viewport height; show paragraph region; clean up source code (boilerplate & organization) Oct 27, 2017
@JordanMartinez JordanMartinez merged commit e4ad3b3 into FXMisc:master Oct 27, 2017
@JordanMartinez JordanMartinez deleted the viewportHeightAndReduceBoilerplate branch October 27, 2017 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant