Allow multiple portions of an area's document to be updated in one call#695
Merged
JordanMartinez merged 6 commits intoFXMisc:masterfrom Mar 6, 2018
JordanMartinez:multiTextChange
Merged
Allow multiple portions of an area's document to be updated in one call#695JordanMartinez merged 6 commits intoFXMisc:masterfrom JordanMartinez:multiTextChange
JordanMartinez merged 6 commits intoFXMisc:masterfrom
JordanMartinez:multiTextChange
Conversation
Contributor
Author
|
The issue in my custom UndoManager is that an undo change must be applied differently than a redo change. Whereas an undo might use a relative replace from MultiChangeBuilder, the redo must use an absolute replace. Thus, UndoFX needs to provide more flexibility in its underlying UndoManager. |
This was referenced Mar 7, 2018
Contributor
|
@JordanMartinez many thx for implementing this 👍 I tried it in Markdown Writer FX and ran into an issue in undo. Here is a test case (for @Test
public void committing_relative_change_backtofront_works() {
interact(() -> {
String text = area.getText();
String hello = "hello";
String world = "world";
area.createMultiChange(2)
.insertText(6, world)
.insertText(0, hello)
.commit();
assertEquals(hello + text + world, area.getText());
area.undo();
assertEquals(text, area.getText());
});
}Test output: |
Contributor
Author
|
@JFormDesigner Thanks for reporting that. I'm looking into it now. I'd guess that it has to do with using a relative replace in MultiChangeBuilder when undoing a change rather than an absolute replace. |
This was referenced Apr 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #574.