API for visible paragraphs works when contents have blank lines#790
Closed
lhttjdr wants to merge 2 commits intoFXMisc:masterfrom
Closed
API for visible paragraphs works when contents have blank lines#790lhttjdr wants to merge 2 commits intoFXMisc:masterfrom
lhttjdr wants to merge 2 commits intoFXMisc:masterfrom
Conversation
Collaborator
|
Thanks, this was covered by the PR fix #795 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These test cases are for issue #777.
It shows that
firstVisibleParToAllParIndex,lastVisibleParToAllParIndexandvisibleParToAllParIndexwill throw out "Unreachable code" errors when the contents have blank lines/paragraphs.However, it not always behaves like that.
visibleParToAllParIndexwill works correctly even there are some blank lines.What I know now is that
getVisibleParagraphsreturns wrong list corresponding to blank lines, so that all those 3 functions above won't work because it's impossible to find a same item in list returned fromgetParagraphs.