Fix for #812 caretBounds graphic bug#819
Merged
Jugen merged 1 commit intoFXMisc:masterfrom May 14, 2019
Jugen:Fix-for-issue-812
Merged
Fix for #812 caretBounds graphic bug#819Jugen merged 1 commit intoFXMisc:masterfrom Jugen:Fix-for-issue-812
Jugen merged 1 commit intoFXMisc:masterfrom
Jugen:Fix-for-issue-812
Conversation
Remove listeners from selections and carets before clearing in method dispose, otherwise the clear triggers a selection path update that results in an errant selection path appearing at the current cursor position.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ParagraphText.dispose() listeners need to be remove from selections and carets before clearing, otherwise the clear triggers a selection path update that results in an errant selection path appearing at the current cursor position.