Fixed RichTextChange reported by ReadOnlyStyledDocument replace#908
Merged
Jugen merged 1 commit intoFXMisc:masterfrom Mar 5, 2020
Jugen:Fix_unexpected_change_received
Merged
Fixed RichTextChange reported by ReadOnlyStyledDocument replace#908Jugen merged 1 commit intoFXMisc:masterfrom Jugen:Fix_unexpected_change_received
Jugen merged 1 commit intoFXMisc:masterfrom
Jugen:Fix_unexpected_change_received
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #904
The problem turned out to be that when ReadOnlyStyledDocument does a replace then it is assumed that the provided replacement is the actual change that has occurred in the document. This is not always the case though due to paragraph concatenation having various rules determining if the left or right hand side style is going to be used if either of the paragraphs is empty.