Skip to content

Fix tests not on fx thread #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jugen merged 3 commits into from
Mar 19, 2020
Merged

Fix tests not on fx thread #917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a222d2a
Fixed testForBug904 FX thread exception
Jugen Mar 19, 2020
8254dbf
Fixed initial range test FX thread exception
Jugen Mar 19, 2020
a8b844d
Fixup missing bracket
Jugen Mar 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion richtextfx/src/integrationTest/java/org/fxmisc/richtext/api/UndoManagerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ public void testForBug904() {
interact( () -> area.setStyle( 5, 9, "-fx-font-weight: bold;" ) );
write( "new line" );
area.getUndoManager().preventMerge();
area.append( area.getContent().subSequence( firstLine.length()-1, area.getLength() ) );
interact( () -> area.append( area.getContent().subSequence( firstLine.length()-1, area.getLength() ) ) );
interact( area::undo ); // should not throw Unexpected change received exception
}

Expand Down
6 changes: 4 additions & 2 deletions richtextfx/src/integrationTest/java/org/fxmisc/richtext/api/selection/PositionTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,10 @@ private void selectRight() {

@Test
public void initial_range_specified_via_constructor_is_honored() {
area.appendText( "\n"+ fullText );
area.appendText( "\n"+ fullText );
interact(() -> {
area.appendText( "\n"+ fullText );
area.appendText( "\n"+ fullText );
});

int paragraphOne = 1;
int start = area.getAbsolutePosition( paragraphOne, leftText.length() );
Expand Down
⚡