Accommodate selection when following caret#933
Merged
Jugen merged 1 commit intoFXMisc:masterfrom Jun 25, 2020
Jugen:master
Merged
Accommodate selection when following caret#933Jugen merged 1 commit intoFXMisc:masterfrom Jugen:master
Jugen merged 1 commit intoFXMisc:masterfrom
Jugen:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #932
Ordinarily when a caret ends a selection in the target paragraph and scrolling left is required to follow
the caret then the selection won't be visible as it'll be just off to the left of the screen.
This PR adds a check for this scenario and adjusts follow caret so that the selection becomes visible as well.