fix: defer collapse of current panel to next frame for smoother trans…#1613
Merged
shahar-biron merged 3 commits intostagingfrom Apr 9, 2026
Merged
fix: defer collapse of current panel to next frame for smoother trans…#1613shahar-biron merged 3 commits intostagingfrom
shahar-biron merged 3 commits intostagingfrom
Conversation
Completed Working on "Code Review"✅ Code review complete. No issues found - all changes look good! ✅ ✅ Workflow completed successfully. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe panel collapse effect in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Suggested PR titles:
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔒 Trivy Security Scan Results |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/providers.tsx`:
- Around line 727-733: The scheduled requestAnimationFrame callback that calls
currentPanel.collapse() can run after effect cleanup and collapse the wrong
panel; change the code around the requestAnimationFrame(...) call to capture its
return value (raf id) and cancel it on effect cleanup using
cancelAnimationFrame(rafId) so any pending frame is cleared when
pathname/graphName or the effect unmounts, ensuring currentPanel.isCollapsed()
check/collapse only runs while the effect is still valid.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 62cef230-a169-4313-8d0b-62570e88a126
📒 Files selected for processing (1)
app/providers.tsx
shahar-biron
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…itions
Summary by CodeRabbit