Empty line no longer added to start of strings files on sort#180
Empty line no longer added to start of strings files on sort#180Jeehut merged 2 commits intoFlineDev:mainfrom
Conversation
CHANGELOG.md
Outdated
| - None. | ||
| ### Fixed | ||
| - None. | ||
| - Normalize sortByKeys no longer adds empty line to begining of .strings file. |
There was a problem hiding this comment.
Two whitespaces missing at the end of this line.
CHANGELOG.md
Outdated
| ### Fixed | ||
| - None. | ||
| - Normalize sortByKeys no longer adds empty line to begining of .strings file. | ||
| Issues: [#178](https://github.com/Flinesoft/BartyCrouch/issues/178) |
There was a problem hiding this comment.
Two whitespaces missing at the beginning of this line. Also, please singularize to Issue, add the PR: link and yourself as the Author:.
There was a problem hiding this comment.
Added the changes. Please note that requiring the PR number in the change log creates a chicken and egg problem as I don't know the PR number until I actually try to create the PR, at which point in time I've already committed and pushed ;)
There was a problem hiding this comment.
The idea is that you start a PR with your changes and make a commit like Document changes of PR #180 after the PR is online with the changes to the Changelog. Maybe I should document this somewhere. But in general you are right and I don't require the PR, I just mentioned it because the Issue and Author also were not quite right. :)
Jeehut
changed the title
|
@hactar Noticed one more thing: You've added a |
|
Sorry bout that, but I'm afraid that goes beyond the scope of things I can quickly do via git. |
|
Ok, sure, no worries. Merging, thank you! 🎉 |
2 participants
As discussed in #178 - when normalising and sortByKeys = true, BartyCrouch adds a new line to the start of every strings file. This PR resolves this issue.