Skip to content

Fix IDOR in Evaluators and Evaluations Endpoints #6050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yau-wd merged 3 commits into from
Apr 1, 2026
Merged

Fix IDOR in Evaluators and Evaluations Endpoints #6050

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1033b1e
Fix IDOR in Evaluators and Evaluations Endpoints
Mar 24, 2026
319e9a1
Merge branch 'main' into flowise-323-evaluations
yau-wd Apr 1, 2026
5a6d99b
chore(services/evaluations & EvaluatorDTO): replace explicit field as…
yau-wd Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/server/src/Interface.Evaluation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ export class EvaluatorDTO {

static toEntity(body: any): Evaluator {
const newDs = new Evaluator()
Object.assign(newDs, body)
newDs.name = body.name
newDs.type = body.type
Comment thread
christopherholland-workday marked this conversation as resolved.
Outdated
let config: any = {}
if (body.type === 'llm') {
config = {
Expand Down
8 changes: 7 additions & 1 deletion packages/server/src/services/evaluations/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,13 @@ const createEvaluation = async (body: ICommonObject, baseURL: string, orgId: str
try {
const appServer = getRunningExpressApp()
const newEval = new Evaluation()
Object.assign(newEval, body)
Comment thread
yau-wd marked this conversation as resolved.
newEval.name = body.name
newEval.evaluationType = body.evaluationType
newEval.chatflowId = body.chatflowId
newEval.chatflowName = body.chatflowName
newEval.datasetId = body.datasetId
newEval.datasetName = body.datasetName
newEval.workspaceId = workspaceId
Comment thread
christopherholland-workday marked this conversation as resolved.
Outdated
newEval.status = EvaluationStatus.PENDING

const row = appServer.AppDataSource.getRepository(Evaluation).create(newEval)
Expand Down
2 changes: 2 additions & 0 deletions packages/server/src/services/evaluator/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ const createEvaluator = async (body: any) => {
try {
const appServer = getRunningExpressApp()
const newDs = EvaluatorDTO.toEntity(body)
newDs.workspaceId = body.workspaceId
Comment thread
christopherholland-workday marked this conversation as resolved.

const evaluator = appServer.AppDataSource.getRepository(Evaluator).create(newDs)
const result = await appServer.AppDataSource.getRepository(Evaluator).save(evaluator)
Expand All @@ -78,6 +79,7 @@ const updateEvaluator = async (id: string, body: any, workspaceId: string) => {

const updateEvaluator = EvaluatorDTO.toEntity(body)
updateEvaluator.id = id
updateEvaluator.workspaceId = workspaceId
Comment thread
christopherholland-workday marked this conversation as resolved.
appServer.AppDataSource.getRepository(Evaluator).merge(evaluator, updateEvaluator)
const result = await appServer.AppDataSource.getRepository(Evaluator).save(evaluator)
return EvaluatorDTO.fromEntity(result)
Expand Down
Loading
⚡