Skip to content

Fix center image#666

Open
mokraemer wants to merge 11 commits intoFoliotek:masterfrom
mokraemer:fixCenterImage
Open

Fix center image#666
mokraemer wants to merge 11 commits intoFoliotek:masterfrom
mokraemer:fixCenterImage

Conversation

@mokraemer
Copy link
Copy Markdown

if the resulting canvas element is not of the same size as the picture, the picture was not centered in the canvas element

@mandaputtra
Copy link
Copy Markdown

do this fix #419 ?

@mokraemer
Copy link
Copy Markdown
Author

I would say "yes". If I use our patched version (https://static.qmsystems.de/js/lib/croppie.js), I can't reproduce the issues I see with the original lib.
Since this is the first time I use git, not all patches from obove apply to this FR/bug.

@vandensudarsono
Copy link
Copy Markdown

it seem your changes is not included in v.2.6.4 version.

@mokraemer
Copy link
Copy Markdown
Author

yes, no one wants to merge...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants