Conversation
fixed errors (return -> return *this where needed)
Collaborator
Author
|
Not sure how to fix the platformIO errors |
Member
|
It's under discussion here, I'll have a look, it's nothing related to this PR. |
franky47
requested changes
Oct 10, 2021
Member
franky47
left a comment
There was a problem hiding this comment.
Apart from the internal method, LGTM.
franky47
approved these changes
Oct 10, 2021
Collaborator
Author
|
added example on how to use command chaining with lambda functions |
added Chaining example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modified all commands, callbacks and setters with no return value (void) to return a reference to this.
example:
becomes
this modif has no impact on existing code, and code size