This repository was archived by the owner on Mar 29, 2024. It is now read-only.
Add support for <template> tags#1
Merged
Ffloriel merged 6 commits intoFullHuman:masterfrom Jan 26, 2019
jarrodldavis:bugfix/template-tags
Merged
Add support for <template> tags#1Ffloriel merged 6 commits intoFullHuman:masterfrom jarrodldavis:bugfix/template-tags
Ffloriel merged 6 commits intoFullHuman:masterfrom
jarrodldavis:bugfix/template-tags
Conversation
Add failing tests for extracting selectors from HTML tags under `<template>` tags.
Organize the existing tests for normal HTML documents into a sub-group.
If a node type is `root`, gather selectors from children.
Add to the existing `selectors` return array when gathering selectors from a `root` type node instead of immediately returning.
Actually use the spread operator when gathering selectors from `root` type nodes.
Ffloriel
approved these changes
Jan 26, 2019
Member
|
Thanks a lot! I missed the notification, sorry about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse5seems to handle<template>tags differently from other tags by wrapping child nodes in aroottype node, which causespurgecss-from-htmlto skip children of template elements altogether. Adding support for<template>nodes supports Single File Components, as used by Vue.js and other frameworks.Here's what I did to support them:
testEnvironmentconfiguration tonodeto avoid errors with JSDOMroottype nodes and adding to theselectorsreturn arrayPlease let me know if you want the
testEnvironmentextracted into a separate PR, or if I should update Jest to a newer version since that error has been fixed.