refactor(ts): migrate config module to use TS and ESM#31
Closed
jescalada wants to merge 18 commits intoG-Research-Forks:mainfrom
Closed
refactor(ts): migrate config module to use TS and ESM#31jescalada wants to merge 18 commits intoG-Research-Forks:mainfrom
config module to use TS and ESM#31jescalada wants to merge 18 commits intoG-Research-Forks:mainfrom
Conversation
2 tasks
config module to use TS and ESMconfig module to use TS and ESM
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
=======================================
Coverage ? 50.99%
=======================================
Files ? 48
Lines ? 1655
Branches ? 81
=======================================
Hits ? 844
Misses ? 794
Partials ? 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Mar 20, 2025
…-plugin-samples - plugins/git-proxy-plugin-samples/package.json
…ples-manager chore(deps): update dependency @finos/git-proxy to ^1.9.3 - git-proxy-plugin-samples - plugins/git-proxy-plugin-samples/package.json
…es/git-proxy-cli/package.json
fix(deps): update dependency axios to ^1.8.4 - git-proxy-cli - packages/git-proxy-cli/package.json
Author
|
PR contents merged in finos#960. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on my previous refactoring PR (#27) to migrate
/src/configfiles to TS and ESM. I modified the logic insrc/config/file.tsto work with ESM imports. When usingget/setexports, these don't actually refresh unless explicitly exporting the desired variable (in this case,configFile).*Note: * I investigated the
ERR_REQUIRE_ESMerror in the CI, which for some reason, works just fine when executingnpm run test-coverage-cilocally. Apparently, this is expected when mixing ESM and CommonJS code in the same module. Source*Note 2: * My fix for the CI issues with ESM/TS was simply removing the dependency with the parent package (by copying the line where the environment variables are fetched). We might face the issue again when migrating the CLI to ESM/TS (if this is a priority).
Changelog
/src/config/to use TS and ESM