Conversation
5hseok
reviewed
May 25, 2025
| .filter(image -> image.getImageUrl().equals(deleteUrl)) | ||
| .forEach(BaseEntity::delete); | ||
| } | ||
| getLost.setLost(updateLostRequestDto); |
Member
There was a problem hiding this comment.
코드 가독성이 좋지 않은 것 같네요....
getLost.setLost로는 무슨 코드인지 알기 어려워용
나중에 수정하는 걸로 합시다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Related Issues
📌 Tasks
공지사항, 분실물 데이터 수정 기능 추가
이미지 추가 및 이미지 삭제 가능
💬 Additional Notes
기존 Edit 코드는 전부 삭제하고, Update로 수정했습니다.
Edit은 내부 데이터에 대해 수정 삭제가 한 트랜잭션에서 구현되지 않았음.
한 트랜잭션에서 삭제할 url + 추가할 이미지 파일을 받아 삭제와 추가를 한번에 구현
내부 정보도 수정 가능