Merged
Conversation
puretension
requested review from
bianbbc87,
bunju20,
naarang,
seochan99 and
shimseohyun
bianbbc87
approved these changes
Apr 18, 2024
Member
bianbbc87
left a comment
bianbbc87
left a comment
There was a problem hiding this comment.
HeaderTitle, NumberFilterlingButton 공통으로 뽑아내면 너무 좋을 것 같아요! 수고하셨습니다 😄
seochan99
approved these changes
Apr 18, 2024
Member
seochan99
left a comment
seochan99
left a comment
There was a problem hiding this comment.
고생하셨어요~ 다음 PR에 커멘트 반영하셔서 올리시면 될듯!
| src={cardImageUrl} | ||
| alt={title} | ||
| layout='responsive' | ||
| width={1600} |
| quality={100} | ||
| /> | ||
| <div className="absolute bottom-10 left-0 p-4"> | ||
| <h3 className="text-xs text-white">{date}</h3> |
Member
There was a problem hiding this comment.
text-white default라 적용안해도 되는걸로압니다! 나중에 빼도 바뀌는거 없으면 빼주세요!
Comment on lines
+1
to
+11
| /** | ||
| * @description | ||
| * 날짜 표시 헤더 컴포넌트 | ||
| * @component DateHeader | ||
| * @returns {JSX.Element} DateHeader | ||
| * @since 2024.04.17 | ||
| */ | ||
| // components/DateHeader.tsx | ||
| import { DateHeaderProps } from "@/interfaces/timeline/timelineDate"; | ||
| import React from 'react'; | ||
| const DateHeader: React.FC<DateHeaderProps> = ({ date }) => { |
Member
There was a problem hiding this comment.
/**
*
*..
*
/
주석은 component 바로 위에 적어줘야해요
import를 제일 상단에 올리고 이건 내려주셔야합니다
Member
Author
There was a problem hiding this comment.
주석 작성 부분(아래 코멘트 포함) 확인했습니다!
Comment on lines
+1
to
+5
| /* | ||
| 기수별 버튼 컴포넌트(1st, 2nd, 3rd) | ||
| */ | ||
| import React from 'react'; | ||
|
|
Comment on lines
+1
to
+20
| /** | ||
| * @description | ||
| * 각 월별로 그룹화된 타임라인 카드 리스트 섹션 컴포넌트 | ||
| * ex) 2024 January 하고, 해당 월 카드 리스트 렌더링 | ||
| * @component | ||
| * @param {TimelineCardProps[]} timelineData | ||
| * @returns {JSX.Element} | ||
| * @since 2024.04.18 | ||
| */ | ||
| import React from 'react'; | ||
| import groupByMonthYear from "@/utils/timeline/groupByMonthYear"; | ||
| import DateHeader from "../header/DateHeader"; | ||
| import TimelineMonthlyCardSection from "../section/TimelineMonthlyCardSection"; | ||
| import { TimelineCardProps } from "@/interfaces/timeline/timelineCard"; | ||
|
|
||
| interface TimelineMonthlyPartProps { | ||
| timelineData: TimelineCardProps[]; | ||
| } | ||
|
|
||
| const TimelineMonthlyPart: React.FC<TimelineMonthlyPartProps> = ({ timelineData }) => { |
Comment on lines
+1
to
+10
| // utils/groupTimelineData.ts | ||
| import { TimelineCardProps } from '@/interfaces/timeline/timelineCard'; | ||
| import { formatDate } from "./formDate"; | ||
|
|
||
| /** | ||
| * 그룹화 함수: TimelineCardProps 배열을 받아 '년 월'로 그룹화하고 내림차순으로 정렬된 객체를 반환. | ||
| * @param {TimelineCardProps[]} data - 타임라인 카드 데이터 배열 | ||
| * @returns {Record<string, TimelineCardProps[]>} - '년 월'로 그룹화하고 내림차순으로 정렬된 객체 | ||
| */ | ||
| const groupByMonthYear = (data: TimelineCardProps[]): Record<string, TimelineCardProps[]> => { |
Comment on lines
+7
to
+14
| const borderColor = isActive ? 'white' : '#536E7B'; | ||
| const textColor = isActive ? 'white' : '#536E7B'; | ||
|
|
||
| return ( | ||
| <button | ||
| className="w-10 h-8 bg-transparent border rounded-lg text-xs leading-4 px-2 py-1" | ||
| style={{ borderWidth: '1.5px', borderColor, color: textColor }} | ||
| onClick={() => onClick(label)} |
Member
There was a problem hiding this comment.
${
`isActive ? 'white' : 'bg-[#536E7B]';
..
}
뭐 이런식으로
shimseohyun
approved these changes
Apr 18, 2024
Contributor
There was a problem hiding this comment.
혹시 이거 그라디언트는 css로 주실 수 있으실까요?
이미지 넣을때 하나하나 그라디언트 넣기 너무 힘들 것 같습니다...!
background: linear-gradient(0deg, #1C1D1F 0%, #FFF 100%);
|
|
||
| return ( | ||
| <button | ||
| className="w-10 h-8 bg-transparent border rounded-lg text-xs leading-4 px-2 py-1" |
Contributor
There was a problem hiding this comment.
ㅎㅎㅎ... 다음 수정때 폰트 양식 다 반영해주실 수 있을까요... 너무 늦게말씀드린 것 같다만...
This was referenced Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 타입 ( 하나 이상의 PR 타입을 선택해주세요 )
개요
타임라인 페이지 1차적으로 완성했습니다.
변경 사항
타임라인 페이지 틀만 잡아봤습니다! 매우 디테일한 디자인이나, 모바일 반응형 부분은 우선 코드 컨펌을 받고 개선후에 문제가 없다면 적용시키겠습니다.
코드 리뷰시 참고 사항