Skip to content

Remove brutforce search of the working one plugin when context with requested plugin is can't be created#223

Merged
bsavery merged 1 commit intoGPUOpen-LibrariesAndSDKs:masterfrom
hshakula:fix-context-creation
Jan 15, 2020
Merged

Remove brutforce search of the working one plugin when context with requested plugin is can't be created#223
bsavery merged 1 commit intoGPUOpen-LibrariesAndSDKs:masterfrom
hshakula:fix-context-creation

Conversation

@hshakula
Copy link
Copy Markdown
Contributor

In back old days this behavior was pretty convenient, but right now it confusing.
For example, you have selected High quality, i.e. use Hybrid plugin, but in case Hybrid plugin can't be loaded for some reason Tahoe would be loaded automatically and there would be no sign of problem, of course except logged error message which Houdini tends to hide

@bsavery
Copy link
Copy Markdown
Contributor

bsavery commented Jan 13, 2020

So just to be clear. I think we should grey our or remove the quality options if only tahoe is available...

@hshakula
Copy link
Copy Markdown
Contributor Author

Sure, it would be nice to have such a possibility but neither usdview nor Houdini allows us to modify its UI dynamically:

  • Houdini loads UI from "template" file and creates UI from it
  • usdview generates UI from the set of RenderSettings returned by render delegate (HdRenderDelegate::GetRenderSettingDescriptors)

@bsavery bsavery merged commit d050ce4 into GPUOpen-LibrariesAndSDKs:master Jan 15, 2020
@hshakula hshakula deleted the fix-context-creation branch January 15, 2020 21:45
MagisterDemens pushed a commit to MagisterDemens/RadeonProRenderUSD that referenced this pull request Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants