Skip to content

Fix adaptive sampling#237

Merged
bsavery merged 1 commit intoGPUOpen-LibrariesAndSDKs:masterfrom
hshakula:adaptive-sampling-fix
Feb 21, 2020
Merged

Fix adaptive sampling#237
bsavery merged 1 commit intoGPUOpen-LibrariesAndSDKs:masterfrom
hshakula:adaptive-sampling-fix

Conversation

@hshakula
Copy link
Copy Markdown
Contributor

@hshakula hshakula commented Feb 21, 2020

  • Tahoe requires that AOV_VARIANCE is created for adaptive sampling to work
  • Set RPR_CONTEXT_FRAMECOUNT parameter to the current sample count (should not RPR_CONTEXT_FRAMECOUNT be named as RPR_CONTEXT_SAMPLECOUNT?)

@bsavery
Copy link
Copy Markdown
Contributor

bsavery commented Feb 21, 2020

I agree, the name of RPR_CONTEXT_FRAMECOUNT is confusing. Probably should be RPR_CONTEXT_ITERATIONCOUNT since you can have multiple samples per iteration.

@bsavery bsavery merged commit c81ecc3 into GPUOpen-LibrariesAndSDKs:master Feb 21, 2020
@hshakula hshakula deleted the adaptive-sampling-fix branch February 21, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants