Draft
Conversation
We currently have a bug in __constrainToScreen where windows that are entirely offscreen will be offset by their width and height, potentially moving them even further offscreen. Rather than constraining offscreen windows in this commit, for testing purposes I'm leaving them at their original position and logging some info with the hope to track down an odd configuration issue at Cinesite.
murraystevenson
force-pushed
the
popupWindowDebug
branch
from
fcd3e54 to
a67b158
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR for the purposes of making a build to deploy for testing odd PopupWindow placement behaviour experienced by a user with mixed 4K and 2K monitors at Cinesite.