Cycles ShaderNetworkAlgo : Add support for normal imputs for USDPreviewSurface#6867
Open
boberfly wants to merge 1 commit intoGafferHQ:mainfrom
Open
Cycles ShaderNetworkAlgo : Add support for normal imputs for USDPreviewSurface#6867boberfly wants to merge 1 commit intoGafferHQ:mainfrom
boberfly wants to merge 1 commit intoGafferHQ:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generally describe what this PR will do, and why it is needed
normal_mapnode andvector_mathto normalize. ALab tends to output scale/bias with negative values and will hard-crash Cycles (I wonder if ourmultiply_addapproach to scale/bias textures needsuse_clampenabled?). Should I put preprocessor defines in here for older Cycles versions that don't generate tangents automatically to not load in normals?Related issues
Dependencies
Breaking changes
Checklist