[Perf] Cleanup launch kernel logic#251
Merged
Merged
Conversation
hughperkins
reviewed
Oct 28, 2025
hughperkins
reviewed
Oct 28, 2025
hughperkins
reviewed
Oct 28, 2025
hughperkins
reviewed
Oct 28, 2025
hughperkins
reviewed
Oct 28, 2025
duburcqa
force-pushed
the
duburcqa/cleanup
branch
from
2aa9c2c to
5ca9934
Compare
hughperkins
reviewed
Oct 28, 2025
duburcqa
force-pushed
the
duburcqa/cleanup
branch
from
5ca9934 to
9b64933
Compare
YilingQiao
approved these changes
Oct 28, 2025
hughperkins
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does not aim at improving performance. Just removing unnecessary code complexity and boilerplate. Still the simulation is marginally faster for ndarray (3.31M to 3.35M FPS).