Skip to content

Prevent the browser's tab to crash for extent having a non-number height or width#103

Open
qgerome wants to merge 4 commits intoGeoTIFF:masterfrom
qgerome:fix-raster-nan-value
Open

Prevent the browser's tab to crash for extent having a non-number height or width#103
qgerome wants to merge 4 commits intoGeoTIFF:masterfrom
qgerome:fix-raster-nan-value

Conversation

@qgerome
Copy link
Copy Markdown

@qgerome qgerome commented Jul 22, 2022

These variables can be NaN
if (oldrb.width !== 0 && oldrb.height !== 0) {

Example file:
population.cog.tif.zip

@DanielJDufour
Copy link
Copy Markdown
Member

Thank you! Impressive work! I really appreciate you catching this. I think this bug has been causing problems and it didn't know why.

Do you happen to know what values were being passed to new GeoExtent(oldExtentOfInnerTileInRasterCRS.bbox); leading to NaN? Is there a bug in the geo-extent library that I should fix?

@qgerome
Copy link
Copy Markdown
Author

qgerome commented Jul 25, 2022

Yes, I took a screenshot of the variables :
CleanShot 2022-07-25 at 10 20 11@2x

I think the problem is indeed with the subtract operation in geo-extent (https://github.com/DanielJDufour/geo-extent/blob/2ede7c76866e9fd78a426fb1b0463692c1564078/src/geo-extent.js#L159)

@DanielJDufour
Copy link
Copy Markdown
Member

wow. I really appreciate you finding the root cause of the problem! I created an issue with preciso and will fix there: DanielJDufour/preciso#7

@DanielJDufour
Copy link
Copy Markdown
Member

I think the issue might have been geo-extent using an old broken version of preciso. Will republish soon

@DanielJDufour
Copy link
Copy Markdown
Member

Rebuilding / Republishing hit a snag with some dependency typings. I can fix it, but it will unfortunately probably take a day or more.

@qgerome
Copy link
Copy Markdown
Author

qgerome commented Jul 25, 2022

No problem for the timeline :)

Since the error is from an external dependency, do you prefer I remove the commit that checks if it's different than 0 or is it ok for you as-is ?

@DanielJDufour
Copy link
Copy Markdown
Member

I just published version 3.9.0-0 as a release candidate, which should fix the previous issue. I'm going to read through this PR again and I'll think about your question more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants