Prevent the browser's tab to crash for extent having a non-number height or width#103
Prevent the browser's tab to crash for extent having a non-number height or width#103qgerome wants to merge 4 commits intoGeoTIFF:masterfrom
Conversation
Instead of expecting drawTile to return it
This fix prevents the browser's tab to crash silently
|
Thank you! Impressive work! I really appreciate you catching this. I think this bug has been causing problems and it didn't know why. Do you happen to know what values were being passed to |
|
Yes, I took a screenshot of the variables : I think the problem is indeed with the |
|
wow. I really appreciate you finding the root cause of the problem! I created an issue with preciso and will fix there: DanielJDufour/preciso#7 |
|
I think the issue might have been geo-extent using an old broken version of preciso. Will republish soon |
|
Rebuilding / Republishing hit a snag with some dependency typings. I can fix it, but it will unfortunately probably take a day or more. |
|
No problem for the timeline :) Since the error is from an external dependency, do you prefer I remove the commit that checks if it's different than 0 or is it ok for you as-is ? |
|
I just published version 3.9.0-0 as a release candidate, which should fix the previous issue. I'm going to read through this PR again and I'll think about your question more. |

These variables can be
NaNif (oldrb.width !== 0 && oldrb.height !== 0) {Example file:
population.cog.tif.zip