Fix tests for #54 and add missing ones for full coverage#61
Fix tests for #54 and add missing ones for full coverage#61geekdave merged 3 commits intoGeppettoJS:masterfrom
Conversation
context.parentContext just needs to be a reference to the parent context. createChildResolver function not required. No need to go to the parent context to do anything as the parent has no need to be aware of the child's existence (it's the child that must reference the parent). Original createChildResolver function was calling "child" a resolver based on the parent context as this._context is the parent context when the function is called.
|
Ahh! good! I had asked if you wanted me to change the tests because it involved removing existing tests concerning the BTW, I'm so busy with a conversion to Geppetto that I've undertaken lately that I'm having a hard time keeping up with the discussions here. But if fixed parent contexts are to be included in the patch release, perhaps there would be an interest in a little but extremely useful function function I've added and am using a lot. I call it |
Fix tests for #54 and add missing ones for full coverage
|
Looks great, @creynders ! Any more changes you want to get in before we create a new release? @mmikeyy : With regard to bubbling events to multiple levels of parents, I think it could be useful. Please feel free to create a PR for this. There is some history/discussion on that here as well: #34 |
3 participants
Hey @mmikeyy I hope you don't mind but I modified the tests to make #54 pass. Sorry, just eager to getting a patch release and definitely wanted to squeeze your changes in too.
@geekdave I added a few uncovered testing paths as well, no major stuff, just keeping that percentage up there.