Skip to content

refactor: BaseUrl 변경#100

Merged
Yejiin21 merged 3 commits intodevelopfrom
refactor/#99/baseurl-refac
Apr 15, 2025
Merged

refactor: BaseUrl 변경#100
Yejiin21 merged 3 commits intodevelopfrom
refactor/#99/baseurl-refac

Conversation

@Yejiin21
Copy link
Copy Markdown
Contributor

@Yejiin21 Yejiin21 commented Apr 15, 2025

Summary by CodeRabbit

  • Chores
    • 환경 변수 예시 파일에서 더 이상 사용하지 않는 항목을 제거했습니다.
    • API 기본 URL을 새로운 도메인으로 변경했습니다.
    • 로그인 시 리다이렉트 주소가 환경 변수 기반으로 동작하도록 개선했습니다.
    • 개발 서버 설정을 업데이트하여 네트워크 접근성과 호스트 제한을 조정했습니다.

@Yejiin21 Yejiin21 linked an issue Apr 15, 2025 that may be closed by this pull request
@Yejiin21 Yejiin21 self-assigned this Apr 15, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 15, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

이 변경사항은 API 및 OAuth2 인증 관련 URL을 기존의 하드코딩된 IP 주소에서 새로운 도메인(api.gotogether.io.kr)과 환경 변수(VITE_API_BASE_URL)를 활용하는 방식으로 전환합니다. 또한, Vite 개발 서버 설정이 네트워크 인터페이스 전체에서 수신하도록 수정되었고, 허용된 호스트가 gotogether.io.kr로 제한되었습니다. 불필요한 환경 변수 예시(VITE_HEADER_TOKEN)가 .env.example에서 제거되었습니다.

Changes

파일/경로 변경 요약
.env.example VITE_HEADER_TOKEN 환경 변수 예시 제거. 나머지 변수는 변경 없음.
src/shared/types/api/http-client.ts axios의 기본 baseURL을 기존 EC2 IP에서 http://api.gotogether.io.kr:8080/api/v1로 변경.
src/widgets/main/ui/LoginModal.tsx Kakao/Google OAuth2 로그인 URL을 하드코딩된 IP에서 환경 변수(VITE_API_BASE_URL) 기반 동적 URL로 변경.
vite.config.ts API base URL 기본값을 새 도메인으로 변경, 서버가 모든 인터페이스에서 수신 및 허용 호스트를 제한하도록 수정.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Frontend (LoginModal)
    participant API Server (api.gotogether.io.kr)

    User->>Frontend (LoginModal): 로그인 버튼 클릭
    Frontend (LoginModal)->>API Server: OAuth2 인증 URL (환경 변수 기반)로 리다이렉트
    API Server-->>User: OAuth2 인증 플로우 진행
Loading

Possibly related PRs

Poem

🐰
새로운 주소로 hop, hop, hop!
환경 변수에 담아둔 꿈을 꾼다네.
로그인도, API도 한결 깔끔하게—
토끼는 오늘도 코드밭에서 춤춘다네.
gotogether.io.kr, 이제 우리 집이지!

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 26906d8 and 31f5850.

📒 Files selected for processing (4)
  • .env.example (1 hunks)
  • src/shared/types/api/http-client.ts (1 hunks)
  • src/widgets/main/ui/LoginModal.tsx (1 hunks)
  • vite.config.ts (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Yejiin21 Yejiin21 added the 🪄 Refactoring 코드 리팩토링 label Apr 15, 2025
@Yejiin21 Yejiin21 requested a review from hyeeuncho April 15, 2025 14:16
Copy link
Copy Markdown
Member

@hyeeuncho hyeeuncho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘했어요

@Yejiin21 Yejiin21 merged commit bcacd92 into develop Apr 15, 2025
0 of 2 checks passed
@Yejiin21 Yejiin21 deleted the refactor/#99/baseurl-refac branch April 15, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪄 Refactoring 코드 리팩토링

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[refactor] BaseUrl 변경

2 participants