refact: ticket api 리팩토링 #109
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,19 @@ | ||
| import { axiosClient } from "../../../shared/types/api/http-client"; | ||
| import { CreateTicketRequest, ReadTicketResponse } from "../model/ticketInformation"; | ||
|
|
||
| export const createTicket = async (data: CreateTicketRequest) => { | ||
| const response = await axiosClient.post('/tickets', data); | ||
| return response.data; | ||
| } | ||
|
|
||
| export const readTicket = async (eventId: number): Promise<{ isSuccess: boolean; result: ReadTicketResponse[] }> => { | ||
| const response = await axiosClient.get("/tickets", { | ||
| params: { eventId }, | ||
| }); | ||
| return response.data; | ||
| } | ||
|
|
||
| export const deleteTicket = async (ticketId: number) => { | ||
| const response = await axiosClient.delete(`/tickets/${ticketId}`); | ||
| return response.data; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| import { useMutation, useQuery } from "@tanstack/react-query"; | ||
| import { createTicket, deleteTicket, readTicket } from "../api/ticket"; | ||
| import { CreateTicketRequest, ReadTicketResponse, TicketResponse } from "../model/ticketInformation"; | ||
|
|
||
| export const useTickets = (eventId: number) => { | ||
| return useQuery<{ isSuccess: boolean; result: ReadTicketResponse[] }>({ | ||
| queryKey: ['tickets', eventId], | ||
| queryFn: () => readTicket(eventId), | ||
| enabled: !!eventId, | ||
| }); | ||
| }; | ||
|
|
||
| export const useCreateTicket = () => { | ||
| return useMutation<TicketResponse, Error, CreateTicketRequest>({ | ||
| mutationFn: createTicket, | ||
| onSuccess: () => { | ||
| alert('티켓이 성공적으로 저장되었습니다.'); | ||
| window.location.reload(); | ||
| }, | ||
| onError: () => { | ||
| alert('티켓 저장에 실패했습니다. 다시 시도해주세요.'); | ||
| }, | ||
| }); | ||
| }; | ||
|
|
||
| export const useDeleteTicket = () => { | ||
| return useMutation<TicketResponse, Error, number>({ | ||
| mutationFn: deleteTicket, | ||
| onSuccess: () => { | ||
| alert("티켓이 삭제되었습니다."); | ||
| window.location.reload(); | ||
| }, | ||
| onError: () => { | ||
| alert('티켓 삭제 중 오류가 발생했습니다.'); | ||
| } | ||
| }); | ||
| }; | ||
|
Comment on lines
+26
to
+37
There was a problem hiding this comment. 🛠️ Refactor suggestion useDeleteTicket 훅에도 동일한 개선이 필요합니다. 삭제 훅도 마찬가지로 페이지 리로드 대신 쿼리 무효화를 통한 데이터 갱신 방식으로 개선이 필요합니다. 다음과 같이 개선해보세요: export const useDeleteTicket = () => {
+ const queryClient = useQueryClient();
return useMutation<TicketResponse, Error, number>({
mutationFn: deleteTicket,
onSuccess: () => {
alert("티켓이 삭제되었습니다.");
- window.location.reload();
+ // 모든 티켓 쿼리 무효화
+ queryClient.invalidateQueries({ queryKey: ['tickets'] });
},
onError: () => {
alert('티켓 삭제 중 오류가 발생했습니다.');
}
});
};또한 삭제 함수에 이벤트 ID를 함께 전달하여 특정 이벤트의 티켓 쿼리만 무효화하는 방식으로도 구현할 수 있습니다: export const useDeleteTicket = () => {
const queryClient = useQueryClient();
return useMutation<TicketResponse, Error, { ticketId: number, eventId: number }>({
mutationFn: ({ ticketId }) => deleteTicket(ticketId),
onSuccess: (_, { eventId }) => {
alert("티켓이 삭제되었습니다.");
queryClient.invalidateQueries(['tickets', eventId]);
},
// ...
});
};이 방식을 사용하면 특정 이벤트의 티켓 목록만 갱신할 수 있어 더 효율적입니다. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| export interface CreateTicketRequest { | ||
| eventId: number; | ||
| ticketType: string; | ||
| ticketName: string; | ||
| ticketDescription: string; | ||
| ticketPrice: number; | ||
| availableQuantity: number; | ||
| startDate: string; | ||
| endDate: string; | ||
| startTime: string; | ||
| endTime: string; | ||
| } | ||
|
|
||
| export interface TicketResponse { | ||
| isSuccess: boolean; | ||
| code: string; | ||
| message: string; | ||
| result: string; // "ticketId: 2" | ||
| } | ||
|
|
||
| export interface ReadTicketResponse { | ||
| ticketId: number; | ||
| ticketName: string; | ||
| ticketDescription: string; | ||
| ticketPrice: number; | ||
| availableQuantity: number; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
useCreateTicket 훅에 개선이 필요합니다.
티켓 생성을 위한 훅이 잘 구현되었지만, 페이지 리로드 방식에 개선이 필요합니다.
현재 방식은
window.location.reload()를 사용하여 전체 페이지를 새로고침하고 있습니다. 이는 사용자 경험을 저하시키고, React Query의 장점을 충분히 활용하지 못합니다. 다음과 같이 개선해보세요:export const useCreateTicket = () => { return useMutation<TicketResponse, Error, CreateTicketRequest>({ mutationFn: createTicket, onSuccess: () => { alert('티켓이 성공적으로 저장되었습니다.'); - window.location.reload(); + // 쿼리 무효화를 통해 데이터 갱신 + // queryClient.invalidateQueries(['tickets']); }, onError: () => { alert('티켓 저장에 실패했습니다. 다시 시도해주세요.'); }, }); };이를 위해서는
QueryClient인스턴스에 대한 접근이 필요합니다. 다음과 같이 모듈 최상단에useQueryClient를 추가하고 훅 내부에서 사용할 수 있습니다: