-
Notifications
You must be signed in to change notification settings - Fork 0
feat: 이벤트 삭제 구현 #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: 이벤트 삭제 구현 #145
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b216bf7
feat: 이벤트 삭제 버튼 퍼블리싱
Yejiin21 2df0713
feat: 반응형 적용
Yejiin21 2f8ca1c
rename: 이벤트 도메인에 맞게 파일명 수정
Yejiin21 9170ab7
fix: 파일경로 에러 수정
Yejiin21 177fd95
feat: 이벤트 삭제 API 연동
Yejiin21 902accc
design: 삭제 버튼 프로필 클릭시 나타나도록 수정
Yejiin21 953980e
feat: 내 티켓, 내 호스트 페이지 홈 이동 버튼 추가
Yejiin21 302a8f3
feat: 대시보드 메인페이지에 홈 이동 버튼 추가
Yejiin21 144bd35
feat: 배너 이미지 데이터 없을때 버튼 비활성화 기능 추가
Yejiin21 aa17891
refact: 삭제 버트느 클릭 시 다른 onClick 이벤트 안되도록 리팩토링
Yejiin21 e09bb88
refact: 매개변수 이름 단수형으로 변경
Yejiin21 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
함수 리팩토링의 일관성과 타입 안전성을 검토해주세요.
이벤트 삭제 함수가
deleteEvent에서eventDeletion으로 이름이 변경되고, 타입 어노테이션이 제거되었습니다. 몇 가지 확인이 필요합니다:다음 스크립트로 함수 사용처와 일관성을 확인해보겠습니다:
타입 안전성을 위해 명시적인 반환 타입을 유지하는 것을 권장합니다:
🏁 Script executed:
Length of output: 1097
API 함수
eventDeletion에 명시적 반환 타입 및 제네릭 타입 추가 필요src/entities/event/api/event.ts내 다른 API 함수들과 비교했을 때, 반환 타입 어노테이션과axiosClient.delete제네릭 타입이 빠져 있어 타입 안전성이 떨어집니다.확인 및 조치 사항:
Promise<ApiResponse<…>>)axiosClient.delete<…>제네릭 타입을 추가eventDeletion으로 변경되었는지 재검토예시 변경안:
추가로, API 함수 네이밍 컨벤션을 일관되게 유지하고 싶다면
deleteEvent,getEventDetail)eventDeletion,eventDetail)중 하나로 통일하는 방안을 검토해주세요.
📝 Committable suggestion
🤖 Prompt for AI Agents