Skip to content

fix: 참가자 정보 조회 size 제한 에러 해결#226

Merged
Yejiin21 merged 1 commit intodevelopfrom
fix/#225/participants-size
Jul 7, 2025
Merged

fix: 참가자 정보 조회 size 제한 에러 해결#226
Yejiin21 merged 1 commit intodevelopfrom
fix/#225/participants-size

Conversation

@Yejiin21
Copy link
Copy Markdown
Contributor

@Yejiin21 Yejiin21 commented Jul 7, 2025

Summary by CodeRabbit

  • Refactor
    • 기본 참가자 조회 수를 10명에서 300명으로 상향 조정하여, 한 번에 더 많은 참가자 정보를 불러올 수 있도록 개선되었습니다.
    • 일부 내부 코드가 간결하게 정리되었습니다.

@Yejiin21 Yejiin21 self-assigned this Jul 7, 2025
@Yejiin21 Yejiin21 added the 🛠️ BugFix 오류 해결 과정 기록 label Jul 7, 2025
@Yejiin21 Yejiin21 linked an issue Jul 7, 2025 that may be closed by this pull request
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jul 7, 2025

Walkthrough

useParticipants 훅의 기본 size 파라미터가 10에서 300으로 변경되었습니다. 함수 시그니처가 한 줄로 축약되었으며, useApproveParticipants 내 쿼리 무효화 함수의 화살표 함수 표현이 간결하게 개선되었습니다. 핵심 로직과 에러 처리에는 변화가 없습니다.

Changes

파일/경로 변경 요약
src/features/dashboard/hook/useParticipants.ts useParticipants의 기본 size 10→300, 함수 시그니처 및 쿼리 무효화 함수 표현 간소화

Possibly related issues

Possibly related PRs

Poem

🐰
참가자 훅에 바람이 불어
열 명에서 삼백 명까지 훌쩍!
한 줄로 쏙 들어간 함수,
더 깔끔해진 코드에 토끼도 방긋.
대규모 참가자도 이제 걱정 끝!

Warning

Review ran into problems

🔥 Problems

Check-run timed out after 90 seconds. Some checks/pipelines were still in progress when the timeout was reached. Consider increasing the reviews.tools.github-checks.timeout_ms value in your CodeRabbit configuration to allow more time for checks to complete.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 34ccbcb and d320133.

📒 Files selected for processing (1)
  • src/features/dashboard/hook/useParticipants.ts (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: storybook
🔇 Additional comments (2)
src/features/dashboard/hook/useParticipants.ts (2)

36-36: 코드 간소화 개선 사항

화살표 함수 표현이 더 간결하게 개선되었습니다. 로직은 동일하게 유지되면서 가독성이 향상되었습니다.


8-8: 기본 size 값 10 → 300 변경 영향 검토 필요

useParticipants 훅의 기본 size가 10에서 300으로 크게 증가함에 따라, 다음 사용 지점에서 UI·성능·메모리·네트워크 측면의 영향을 검증해 주세요:

• src/pages/dashboard/ui/ParticipantsMangementPage.tsx (19행)
• src/pages/dashboard/ui/mail/EmailPage.tsx (15행)
• src/pages/dashboard/ui/mail/EmailEditPage.tsx (15행)

제안 사항:

  1. 실제 300개 로드 시 응답 시간 및 렌더링 성능 측정
  2. 메모리 사용량 및 네트워크 페이로드 크기 확인
  3. 필요 시 동적 page/size 조정, 페이지네이션·무한 스크롤 도입 고려
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@SimoKii SimoKii self-requested a review July 7, 2025 02:16
@Yejiin21 Yejiin21 merged commit 2c2ebb0 into develop Jul 7, 2025
1 of 2 checks passed
@Yejiin21 Yejiin21 deleted the fix/#225/participants-size branch July 7, 2025 02:16
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🛠️ BugFix 오류 해결 과정 기록

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix] 참가자 관리 페이지 size 10개 제한 에러

2 participants