Skip to content

refactor: 이벤트 생성 및 수정 중 하이퍼링크 예외처리 구현#237

Merged
xaexunxang merged 2 commits intodevelopfrom
refact/#224/event-creation-modify
Jul 10, 2025
Merged

refactor: 이벤트 생성 및 수정 중 하이퍼링크 예외처리 구현#237
xaexunxang merged 2 commits intodevelopfrom
refact/#224/event-creation-modify

Conversation

@xaexunxang
Copy link
Copy Markdown
Contributor

@xaexunxang xaexunxang commented Jul 10, 2025

이벤트 생성

  • 하이퍼링크 url 미기입으로 인한 disabled 처리
image
  • 하이퍼링크 기입을 완료하거나 추가하지 않았을 때
image image

이벤트 수정

  • 하이퍼링크 title 미기입으로 인한 disabled 처리
image
  • 하이퍼링크 기입 완료
image
  • 관련 링크 추가 시 필수로 titleurl을 작성하도록 구현
  • 관련 링크 추가 시 안내 문구 출력
  • 관련 링크 추가 시 titleurl 중 하나라도 입력하지 않았을 때 다음저장하기 버튼을 비활성화함

Summary by CodeRabbit

  • 신규 기능

    • 참조 링크 입력란에 유효성 검사가 추가되어, 모든 링크의 제목과 URL이 올바르게 입력되어야 저장할 수 있습니다.
    • 링크 입력란에 입력 가이드 문구가 조건부로 표시됩니다.
  • 버그 수정

    • 저장하기 버튼이 링크 입력값이 유효하지 않을 때 비활성화되어 잘못된 데이터 저장을 방지합니다.
  • 스타일

    • 일부 버튼 레이아웃의 불필요한 공백이 정리되었습니다.

@xaexunxang xaexunxang requested review from Yejiin21 and hyeeuncho July 10, 2025 15:28
@xaexunxang xaexunxang linked an issue Jul 10, 2025 that may be closed by this pull request
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jul 10, 2025

## Walkthrough

링크 입력의 유효성 검증 로직이 추가되어, 각 링크의 제목과 URL이 모두 입력되어야만 저장이 가능하도록 변경되었습니다. LinkInput 컴포넌트와 이를 사용하는 페이지들에서 유효성 상태를 추적하고, 저장 버튼 활성화 여부에 반영하는 로직이 도입되었습니다.

## Changes

| 파일/경로                                                               | 변경 요약                                                                                                   |
|-------------------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------|
| src/features/event/ui/LinkInput.tsx                                     | `onValidationChange` prop 추가, 링크 유효성 검사 함수 및 useEffect 도입, 입력값 placeholder 및 안내문구 수정 |
| src/pages/dashboard/ui/EventDetailPage.tsx                              | 링크 유효성 상태 관리 및 저장 버튼 활성화 제어, LinkInput에 검증 콜백 연동                                    |
| src/pages/event/ui/create-event/EventInfoPage.tsx                       | 링크 유효성 상태 및 검증 콜백 관리, 전체 유효성 검사에 링크 유효성 반영                                      |
| src/shared/ui/backgrounds/EventRegisterLayout.tsx                       | Header의 JSX 포매팅 단순화 (로직 변경 없음)                                                                  |

## Sequence Diagram(s)

```mermaid
sequenceDiagram
    participant User
    participant LinkInput
    participant ParentPage

    User->>LinkInput: 링크 입력/수정
    LinkInput->>LinkInput: validateLinks() 실행
    LinkInput-->>ParentPage: onValidationChange(isValid)
    ParentPage->>ParentPage: isLinkValid 상태 갱신
    ParentPage->>ParentPage: 저장 버튼 활성/비활성 처리

Possibly related PRs

Suggested labels

🪄 Refactoring

Suggested reviewers

  • hyeeuncho

Poem

🐰
링크마다 이름, 주소 꼼꼼히 채워
저장 버튼은 이제 똑똑해졌죠!
토끼는 깡총, 검증도 깡총
빈칸이 있다면 멈춰서 고민
완벽한 이벤트, 우리 함께 만들어요!
📝✨


<!-- walkthrough_end -->


---

<details>
<summary>📜 Recent review details</summary>

**Configuration used: CodeRabbit UI**
**Review profile: CHILL**
**Plan: Pro**


<details>
<summary>📥 Commits</summary>

Reviewing files that changed from the base of the PR and between dbe5326b78809134693526b061ab5e9f10e52e91 and c97ea5a0454f8566946ff980133dd031b40c1610.

</details>

<details>
<summary>📒 Files selected for processing (4)</summary>

* `src/features/event/ui/LinkInput.tsx` (5 hunks)
* `src/pages/dashboard/ui/EventDetailPage.tsx` (2 hunks)
* `src/pages/event/ui/create-event/EventInfoPage.tsx` (3 hunks)
* `src/shared/ui/backgrounds/EventRegisterLayout.tsx` (1 hunks)

</details>

<details>
<summary>🚧 Files skipped from review as they are similar to previous changes (4)</summary>

* src/shared/ui/backgrounds/EventRegisterLayout.tsx
* src/pages/event/ui/create-event/EventInfoPage.tsx
* src/pages/dashboard/ui/EventDetailPage.tsx
* src/features/event/ui/LinkInput.tsx

</details>

<details>
<summary>⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)</summary>

* GitHub Check: storybook

</details>

</details>
<!-- internal state start -->


<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEYDEZyAAUASpETZWaCrKNxU3bABsvkCiQBHbGlcABpIcVwvOkgAIn8AMzQxfAouQBdxwBKewA6lyEBdgcBGQchAeB7IQAwhwFQJyEBESchADVX0wB9lwEHOwBsFyEAIMcAPMcAMmcAazshAG1rAEDXQ2PtsAWZ1Gno5SGxESkgADzQSFewMNYwiSAAKW0gzACYAZgB2AEpw+AxcCkVsBmlIDZfucXwsWExaLzuewSqUgsFk3EoAIwAGtkLRsBRAW8pPdGP5qPBvugMPRmIp4Al4AwMVi7hFYCRIAlHvcyPQ0NxuADiV8MBojABpEjyBi/XavO4MLzYJQcIxQAAiCKRJBRuDRJBJGDFkF0MApcQAchtcOMQbEAMpoKTjAR4AhYVC0JAqaL0AnkylgiEUKHQyAAVRsABkUMgMPh5exKHR2aqoAB1ClYXAa52Qu7ur2+1AkdQUvgJbxeeTB/z0EEB+VoWhKenFnzhWOUu40ChJF6QAQkX5SZDJJgUa27HPhNDIRCwfAAd0tMY1vHwEngZfsDH8ZEHgcQ7IMkulu2R7EgeOthJZmOVBnD6spsW1K11/D4huNJFN5tJcJtAjtKASjtB4ITMIi6mifo7kgiCAmGapRmQn7xq6iZ/lENbIFmPi5rS+ZVhqtaUA2lLYNwtDUK8HapN2RA5quACCpbqIeaC+PAzBMiQbD3EqiBilAABCgawFB34wb+kQAX8no+ug/h+IE2DwPmVLwCQXi0Mgw7RugVGbv4XgEfQbormukDkWOwIUMwSq0Tu0iIGgpCAdaiBMmgsgxMpkEliREmabMkA6eyUAAJIfmm1Z8NWcEASCyaAdMiAgbs6FnheV7CbeJpNo+GDtuJtm2jEBA8P4cooBgTAMdENATFMwGHrpBhwJSng+BJQQhIVQoiq8zDeOIjFzgu6VDrgcJMd8iAPBim4hR6vlNi2xqYpmILVkskASLRM6sZA8KIpusrbvOiqsti9B0NRuwaKe/BSFQDVEPgZmoLli4IpSsbUO5WleYmyCtpSxWMWVdxGSZB3NkZdWPC8x2xSgDGPNOm74bgaCFTQRCIrg8jCYsywbC6clFSQq76MY4BQHS/AfmgeCEKQ5BUJ5xXMZweX8MIojiG2TY8ooyiqOoWg6ETJhQO4yCoJgOAEMQZDKPTLCM1wVDDhMTguJzChKFQvOaNouhgIYxOmAYiAUAwAD0CT7U9iCmzt9ym1JpveomvkYJ4mgDSsYqxN7BgWPpvlS7T70OCr8j4B+vKYKQiBuBqAAGTswi7btxwoDHfNuw79m8l50k56boJA5BK/gnw0b4k7cJAcffAAaqtCOHgAwnypCpy9xYMB8A2FwI+D4NE4t3NaB7jRqK0Ata6Pk+gDXefp1cT2tNCJ7CqdZkVB1Z+2pY5fgy2UAS8gd28yQ8W6hWfgCI2gtnAYYGATGfMfiKsDEceCSQqfCXHCJeOvckFKIHCP4XACIMBIgeMEd8V8kDylTAxaeIJaK+B0mJSkS9aBnXItXLGABRBIFsxCpyHPgd029kaPHhC8eguUKBbHJKgTBSpIDOXIJdT8ccdLfwoFQHkrdpC3AwBIMhSIa4YHrpPJULco5f1YQXEKzCDr+AcF4TQ51foZ3uAAci+oqDWrDs67gJHJWh+9BTCiUIXJgOJqLfDMhSLwLoIg6nsEOUcrCVJBQQugeUg8b4Zw+jCIRI16FiCRFjCgyBcqEgan3WMX4XQX2EhFQk8lFLYKoqyFBsg4o8E0i8IcCllg0EvFSBaGpP6FTdoY5Akd+T0GpCwOIgAOGcAA4TbRxi5ViA0ForRYhnVqtDbgqR5QjQIozWpCw8LvVyhYtquClgEKIbgOOq5zCWHImomWVUIj7xCkoIUzh1rhxziMignkQSeFfESN49xqLSHFPpXeBYy72Iro8Ku4jJHL2bgIgA/FwfYSAfm0C4H3AeioMBXEgAAXj0MtfAM5277PjqvZOeArCfMQKnTC9ZkgEz0h6GZnkE7O1dngVOmjyCohAkQDA1Anp7JapYyk3yG7SIEanSuXBIDHkgAAMUeMwVU/K442Jvuiil8pYUHAAN7LVosEcI3wZH8nCLbXABpEY0HCEsXAeC5TaoIpAAAvlwKVbssWl0QFcVOfLVTQH3g66uEr5SWrwHC+VirhQkBVRgNVpANVGp1X6+wJADUhoIv60FnLZFmoteSq12K7UGG9rEcUhtjZm24FZaQpt8KDj7s4Wg9t4Cm0NewCUEbtBeCsHmjQHsvY+z9uRAONMZYxBDiZVWpz6nRyMDg4u9hQ2KsRNlauSBV6gtxaLe4VDnh7wiFQBg7pFEN3UGHD8IVEghnxkE2E2Db44miJmLY4SsRxz5P8Eg06OWslnapWcuVcII2eggAco6BD9hiFiJRh4JKqIGoMtFSbKVpxGTS+ByAyB8hofIhJSNh2V2rnXe9fzZHt1+PKfwLxJCvFjKga9p6NUMpuWPH6LBIPblykWI+n5c3+FRCofAnqL7/qxOMsBdSBErnOrEQAABOAFLxuogAGOvGPsI0UgYVmlwBaSK+I0lmOmhtF8b42GTsQHeyej6kheCWOEXgmqkSWThnsB0IU0HOBrMIhuZ1NT724ssLw+AiC3JBJQR4fBiNIn7YRcSJklDrN9ps7ZdNdm5QOaITS4XhozxxqM39fBrnMjuZEOSMc9KUVnFxjBzh4DZS4OK4a8oADaU7Eygr1RG3yWnKsNwALpeqxsamg+woEkDtZfOOlb7jVsRvAOteaqVUa0fArAcds2m1zdHAt/ZYDFq7GWitcp+u1vraQRtiAVhxyyy8qk57WRFbdcem92nflYllfsTB4L+6D2hXChFIjkXdd67gNbg2NtyOpduMkk2TbTbzdbQtC3bpLYdm9j7Q3Nse121AAAsop0xkAABSBoAAaM8yVJ2lSN9OUHXurZrZ94bzL5lWOQ58oraGpGskDSQWFcriO3vq7Tw8pq4eQER3uZHaPMenLjhxNKePqOoj+5D4n0O5FzKKqyouJAlY8urllV8dBGcgAqzCUFHO00+zXFmgHM382auW3tAij85QrfYC7YEX2tue11xm1t7bpZ0y7Y4HtW7GC8djmyt7Nv8BfZF2NqZsHMDwZl61KxHGsC5Z3JgPNkyjIHuqXgPjQ6FcjpNStcdqvNPndoKnChtYF00KEdRVaAAvJdH96Ff3CMOAuSNOwqMg25ZnfAr1/GiAXpUKLplvsYZ+giIHKQbDgUiGPXlXO3LJCFX+SzCFsxIf3ch2dX2zPMUVVI5yTVx019CGds9vhEBAlY/fiABWDZIEfn+SBoA6iPxppQdZpgQM3FOZQDVMGbobwgXkgE1YWAua0US68+NOF2AaXKjAKC36q6o+1cHqqyEGIeFCxiSmzKHYJAnwn4w67KbOqq0BHeh0n4DACITG8occu6TGLwq8OKPq0CTSIqccmqrWX8o+S0fmMGucOIpBo2UGgAmATIBT4JAuZKyR5y4Xx3A1I/7ozBatphbrSRYaiHIxYnIBQrDnKXLJaTCpbsAPKZZQAObe6yLRL7wJYXJJY8C6G3L6HTyqHHKshKQhjx5BYaL8Hbg9ZygB5B72DwD0qMriT+AmR3DIDnoCJYKO6ZpgBGBTaDjWaloOxwHQioysY4jWxvY2AkBuYjSUDegOSsbuzbbNpO6bIu5ByeTdrOBe5cG+4mH8g7hI4EYah87lLGTUDiAf7brxzRAJC4BC5ybfD5HNj/x5SlyXzz4AAS+ilAweBOjehGE2mR2RcCeRBRlKZ0vkOGQ0HMOoVA5ArGSkCANAdkBKJBUIlIAg6IsIYkaRtCGoNiU85cEkOIh8XRnCwAvkNiAxFoegReKkccN0kxLAci90de4Qjxi4SI6gVIwqhcHUai8AYAFxmBfhPYJAyJdwY+mhKiIE3wo+4kqAAY9R1kc+GoLmbmDAEJ3wDwA8VIYhKqfAnmIIPmuwAA3PwBgDmJ+K0YDB0dCTvEIIsLMKuAoXWEoaipSA4bFulPFpoYlgWDoTcgwGlgYUYA5uQFEfrvrELHcgWBTFTIHJ2vQAzOwArGgErFUarPMEwBrCoGoNrALHrAYLqQzOoAAPoziIDun5RyTDh0DunjIXK6w6kkwbTNgACsZwJwAAbAIBcAABwJkAAMAAnAAIxnAAAsMZqZZwEZsZAgyZMZ6ZKgEZJAqZCQ6ZyZJABZFZ6ZIZLpYZDAqZFwioEZaAyZWZEZWZCQCZEZMZuZOZhCqZKZmZZwpYyZZw6ZAgWZyZDA6ZJZyZjZTZEAac0wuAnpikPpsofpAZZM+gQAA -->

<!-- internal state end -->
<!-- finishing_touch_checkbox_start -->

<details open="true">
<summary>✨ Finishing Touches</summary>

- [ ] <!-- {"checkboxId": "7962f53c-55bc-4827-bfbf-6a18da830691"} --> 📝 Generate Docstrings

</details>

<!-- finishing_touch_checkbox_end -->
<!-- tips_start -->

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

<details>
<summary>❤️ Share</summary>

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)
- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)
- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)
- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

</details>

<details>
<summary>🪧 Tips</summary>

### Chat

There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=GoTogether-Inc/frontend&utm_content=237):

- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  - `I pushed a fix in commit <commit_id>, please review it.`
  - `Explain this complex logic.`
  - `Open a follow-up GitHub issue for this discussion.`
- Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples:
  - `@coderabbitai explain this code block.`
  -	`@coderabbitai modularize this function.`
- PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.`
  - `@coderabbitai read src/utils.ts and explain its main purpose.`
  - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.`
  - `@coderabbitai help me debug CodeRabbit configuration file.`

### Support

Need help? Create a ticket on our [support page](https://www.coderabbit.ai/contact-us/support) for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

### CodeRabbit Commands (Invoked using PR comments)

- `@coderabbitai pause` to pause the reviews on a PR.
- `@coderabbitai resume` to resume the paused reviews.
- `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
- `@coderabbitai full review` to do a full review from scratch and review all the files again.
- `@coderabbitai summary` to regenerate the summary of the PR.
- `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR.
- `@coderabbitai generate sequence diagram` to generate a sequence diagram of the changes in this PR.
- `@coderabbitai resolve` resolve all the CodeRabbit review comments.
- `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository.
- `@coderabbitai help` to get help.

### Other keywords and placeholders

- Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed.
- Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description.
- Add `@coderabbitai` anywhere in the PR title to generate the title automatically.

### CodeRabbit Configuration File (`.coderabbit.yaml`)

- You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository.
- Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json`

### Documentation and Community

- Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit.
- Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback.
- Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

</details>

<!-- tips_end -->

Copy link
Copy Markdown
Member

@m3k0813 m3k0813 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@xaexunxang xaexunxang force-pushed the refact/#224/event-creation-modify branch from dbe5326 to c97ea5a Compare July 10, 2025 15:49
@github-actions
Copy link
Copy Markdown

@xaexunxang xaexunxang merged commit 51eebe1 into develop Jul 10, 2025
2 checks passed
@xaexunxang xaexunxang deleted the refact/#224/event-creation-modify branch July 10, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[refactor] 이벤트 생성 및 수정 참조링크

2 participants