Skip to content

chore: Google Analytics 배포 버전에 적용하기#241

Merged
xaexunxang merged 1 commit intodevelopfrom
chore/#238/apply-ga
Jul 11, 2025
Merged

chore: Google Analytics 배포 버전에 적용하기#241
xaexunxang merged 1 commit intodevelopfrom
chore/#238/apply-ga

Conversation

@xaexunxang
Copy link
Copy Markdown
Contributor

@xaexunxang xaexunxang commented Jul 11, 2025

Google Analytics 로컬 서버 적용

image
  • 배포 서버에 적용하기 위해서는 PR 적용이 이루어져야함

Summary by CodeRabbit

  • 기능 추가

    • Google Tag Manager(GTM)가 웹사이트에 통합되어 방문자 분석 및 추적이 가능해졌습니다.
  • 버그 수정

    • 인증 코드 전송 및 검증 과정에서 발생하는 오류 메시지 표시 로직이 개선되어, 보다 정확한 오류 안내가 제공됩니다.

@xaexunxang xaexunxang self-assigned this Jul 11, 2025
@xaexunxang xaexunxang added the 👨‍🔧 Chore 환경 설정 label Jul 11, 2025
@xaexunxang xaexunxang linked an issue Jul 11, 2025 that may be closed by this pull request
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jul 11, 2025

Walkthrough

이 변경사항은 Google Tag Manager(GTM)를 HTML 문서에 통합하고, 인증 코드 관련 훅의 에러 처리 로직을 수정합니다. GTM 스크립트와 noscript iframe이 추가되었으며, 인증 코드 훅에서는 에러 메시지의 추출 경로가 변경되었습니다.

Changes

파일/경로 변경 요약
index.html Google Tag Manager(GTM) 스크립트 및 noscript iframe 추가, 기타 포맷팅 조정
src/features/join/hooks/useUserHook.ts 인증 코드 관련 훅의 에러 처리 로직에서 에러 메시지 추출 경로를 error.result에서 error.response.data.result로 변경

Suggested labels

🪄 Refactoring

Poem

토끼가 뛰노는 코드밭에
태그 매니저가 살포시 내려앉네
에러 메시지도 길을 바꿔
더 정확히, 더 똑똑히
변화는 조용히, 기능은 여전히
오늘도 코드밭엔 평화가 흐르네 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 51eebe1 and 0326ab3.

📒 Files selected for processing (2)
  • index.html (1 hunks)
  • src/features/join/hooks/useUserHook.ts (2 hunks)
🔇 Additional comments (4)
index.html (2)

9-18: Google Tag Manager 스크립트 구현이 적절합니다.

표준 GTM 구현 패턴을 따라 head 섹션에 비동기 스크립트를 추가했습니다. 컨테이너 ID 'GTM-MR6M73KS'가 올바르게 설정되어 있습니다.


30-39: noscript 폴백 구현이 적절합니다.

JavaScript가 비활성화된 브라우저를 위한 noscript iframe 폴백이 body 태그 바로 다음에 올바르게 배치되어 있습니다. 이는 GTM 모범 사례를 준수합니다.

src/features/join/hooks/useUserHook.ts (2)

41-42: 에러 처리 로직 업데이트가 적절합니다.

API 응답 구조 변경에 따라 에러 메시지 추출 경로를 error.response?.data.result로 수정했습니다. 중첩된 응답 구조에서 에러 정보를 올바르게 접근하고 있습니다.


60-61: 인증 코드 확인 훅의 에러 처리 로직이 일관되게 적용되었습니다.

인증번호 발급 훅과 동일한 에러 처리 패턴을 적용하여 코드의 일관성을 유지했습니다.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

Copy link
Copy Markdown
Member

@hyeeuncho hyeeuncho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@xaexunxang xaexunxang merged commit 81f5bc7 into develop Jul 11, 2025
2 checks passed
@xaexunxang xaexunxang deleted the chore/#238/apply-ga branch July 11, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👨‍🔧 Chore 환경 설정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[chore] Google Analytics (GA) 적용하기

2 participants