Conversation
2 tasks
Yejiin21
reviewed
Feb 27, 2025
Contributor
Yejiin21
left a comment
Yejiin21
left a comment
There was a problem hiding this comment.
이번 한 주도 고생 많으셨어요! 몇 가지 코멘트 달았습니다:)
| const handleCvcChange = (e: React.ChangeEvent<HTMLInputElement>) => { | ||
| const value = e.target.value.replace(/\D/g, '').slice(0, 3); | ||
| setCvc(value); | ||
| }; |
Contributor
There was a problem hiding this comment.
현재는 useState를 사용하여 각 입력값을 개별적으로 관리하고 있는데, react-hook-form을 사용하면 불필요한 리렌더링을 줄이고, 유효성 검사와 폼 상태 관리를 더 효율적으로 처리할 수 있어서 적용해보는 것도 좋을 것 같아요👍
HSCHEOL
force-pushed
the
feat/#50/payment_page
branch
from
ec8a7d1 to
82de401
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
결제 페이지
카드 등록 버튼
등록된 카드가 없을때
카드 등록 페이지