Skip to content

chore: split lint and lint-fix targets into frontend and backend #6222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DanielRyanSmith wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: split lint and lint-fix targets into frontend and backend #6222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.PHONY: setup clean-setup deps dev-deps dev-ot-key do-tests start-emulator-persist start-emulator \
stop-emulator build tsc-clean watch start-app debug-app start stop test webtest webtest-watch \
webtestpuppeteer webtestpuppeteer-watch webtest-coverage do-coverage coverage view-coverage \
mypy lint lint-fix presubmit pylint openapi openapi-webstatus openapi-frontend openapi-backend \
mypy lint lint-frontend lint-backend lint-fix lint-fix-frontend lint-fix-backend presubmit pylint openapi openapi-webstatus openapi-frontend openapi-backend \
openapi-validate pwtests pwtests-update pwtests-report pwtests-ui pwtests-shell pwtests-debug pwtests-shutdown

setup:
Expand Down Expand Up @@ -107,19 +107,27 @@ view-coverage:
mypy:
. cs-env/bin/activate && mypy --ignore-missing-imports --exclude cs-env/ --exclude appengine_config.py --exclude gen/py/webstatus_openapi/build/ --exclude gen/py/webstatus_openapi/setup.py --exclude gen/py/webstatus_openapi/test/ --exclude gen/py/chromestatus_openapi/build/ --exclude gen/py/chromestatus_openapi/chromestatus_openapi/test --exclude appengine_config.py --no-namespace-packages --disable-error-code "annotation-unchecked" .

lint:
lint-frontend:
npx prettier client-src/js-src client-src/elements client-src/elements packages/playwright/tests --check
npx eslint "client-src/js-src/**/*.{js,ts}" "packages/playwright/tests/*.{js,ts}"
npx tsc -p tsconfig.json
npx lit-analyzer "client-src/elements/chromedash-*.{js,ts}" "packages/playwright/tests/*.{js,ts}"

lint-backend:
$(MAKE) pylint
. cs-env/bin/activate && ruff format --check .

lint-fix:
lint: lint-frontend lint-backend

lint-fix-frontend:
npx prettier client-src/js-src client-src/elements packages/playwright/tests --write
npx eslint "client-src/js-src/**/*.{js,ts}" "packages/playwright/tests/*.{js,ts}" --fix

lint-fix-backend:
$(MAKE) format

lint-fix: lint-fix-frontend lint-fix-backend

format:
. cs-env/bin/activate && ruff check --fix . && ruff format .

Expand Down
Loading
⚡