core: fix crash with Sentry init#13104
Merged
brendankenny merged 1 commit intomasterfrom Sep 22, 2021
Merged
Conversation
patrickhulce
approved these changes
Sep 22, 2021
Collaborator
patrickhulce
left a comment
There was a problem hiding this comment.
worked on v12 and v16 👍
I run into an unrelated issue on v14 though, does anyone else?
file:///Users/patrick/Code/OpenSource/lighthouse/lighthouse-cli/cli-flags.js:15
import {isObjectOfUnknownValues} from '../lighthouse-core/lib/type-verifiers.js';
^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: The requested module '../lighthouse-core/lib/type-verifiers.js' is expected to be of type CommonJS, which does not support named exports. CommonJS modules can be imported by importing the default export.
For example:
import pkg from '../lighthouse-core/lib/type-verifiers.js';
const {isObjectOfUnknownValues} = pkg;
Collaborator
Author
|
Try the lastest 14? |
Contributor
|
works for me in 14.15 (first LTS), 14.16.1, and 14.17.6 (latest LTS) |
Collaborator
|
Alright, then 🤷 (works on latest LTS for me as well) |
Contributor
|
ah, were you running < 14.13? That's when nodejs/node#35249 landed. Makes our increasingly untrue :/ |
Merged
Collaborator
Yeah, I was running 14.8. The matrix of versions that support Lighthouse as a consumer now feels dangerously close to a breaking version change :/ |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #13101
Co-authored-by: Yorkie Liu yorkiefixer@gmail.com