Skip to content

Fix benchmark generator#107

Merged
mathiasbynens merged 1 commit intomainfrom
update-benchmark-generator
Mar 31, 2025
Merged

Fix benchmark generator#107
mathiasbynens merged 1 commit intomainfrom
update-benchmark-generator

Conversation

@mathiasbynens
Copy link
Copy Markdown
Member

No description provided.

@mathiasbynens
Copy link
Copy Markdown
Member Author

As https://github.com/GoogleChromeLabs/jsbi/actions shows, GitHub Actions no longer supports the old Node.js versions we have pinned in this repository, and the build isn’t compatible with more recent Node.js versions. One of the steps towards fixing this is changing the import in the generated benchmark scripts. This patch implements that change and some other changes that were necessary to get the Python script to run.

Copy link
Copy Markdown
Collaborator

@jakobkummerow jakobkummerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mathiasbynens mathiasbynens merged commit 9c9ff05 into main Mar 31, 2025
4 of 5 checks passed
@mathiasbynens mathiasbynens deleted the update-benchmark-generator branch March 31, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants